Re: [E-devel] [Patch][Ecore][Win32] Some Issues

[Kim S. <kim...@gm...>]

Hey,

There are Control Characters.

Previous patch has concerned this as following.

@@ -1148,8 +1159,10 @@ _ecore_win32_event_char_get(int    key,
        break;
      default:
        /* displayable characters */
+       // check control character
+       if ((key > 0) && (key < 27) && (GetKeyState(VK_CONTROL) & 0x8000))
key += 96;

You would know better than me for this.

When it comes to "Control Characters"
The virtual key value for control characters is from 0 to 31 (DEC)
1 -> Ctrl-A
2 -> Ctrl-B

So I add 96 for the control character key.

1 (Ctrl-A) + 96 =  97 (a)

[PS]
------------------------------------------------------------------------
http://www.youtube.com/watch?v=UGmKawTJbjU
Famous Korean Singer sings a song VINCENT :)


2011/11/26 Vincent Torri <vt...@un...>

>
>
> On Fri, 25 Nov 2011, Kim Shinwoo wrote:
>
> > Hello,
> >
> > I have refined and attached the patch.
> > It has ECORE_EVENT_MODIFIER_SHIFT/CTRL/ALT
> > and does NOT have TCHAR.
>
> actually, there are a lot of problems with the keyboard. I'll try to fix
> them. I have no time today, but tomorrow, i'll have more time. I've
> already fixed some. Note : don't test keyboard in virtual box : the vm is
> redirecting the keys.
>
> Vincent
>
> >
> > TGIF!! :-)
> >
> > 2011/11/24 Kim Shinwoo <kim...@gm...>
> >
> >> Thanks for your response!
> >>
> >> I'll refine with ECORE_EVENT_MODIFIER_*.
> >> And TCHAR is already there.. Anyhow, I'll remove it.
> >> Thank you~ :)
> >>
> >>
> >> 2011/11/23 Vincent Torri <vt...@un...>
> >>
> >>>
> >>> Hey
> >>>
> >>> On Wed, 23 Nov 2011, cnook wrote:
> >>>
> >>>> Dear All, Hello~
> >>>>
> >>>> There are some issues as following
> >>>>
> >>>> 1) Key combination like Ctrl + a, Alt +a does not work properly.
> >>>> 2) event->keyname: should be lower case
> >>>> 3) event->modifiers: should be handled -> This is used on the Entry of
> >>>> elementary_test. EX: Ctrl+A should work for selecting all
> >>>> 4) ecore_win32_event_char_get(); is not called when key is released,
> >>>> So, the event ECORE_EVENT_KEY_UP with character does not occur.
> >>>> 5) "Tab" key does not work properly on the Entry of elementary_test.
> >>>> 6) Improper Null check in _ecore_win32_event_char_get(); It returns 1
> >>>> always.. Maybe there is a better solution than my patch.
> >>>> 7) VK_PROCESSKY was not handled. When you click button the
> VK_PROCESSKY
> >>> comes.
> >>>>
> >>>> I think attached patch would be resolved these issues.
> >>>> Please check the patch and give any feedbacks. Thanks
> >>>
> >>> looking at the code (i'm at work right now) :
> >>>
> >>> ECORE_EVENT_MODIFIER_* (in Ecore_Input.h) values must be used.
> >>>
> >>> declare variables at the beginning of the scope
> >>>
> >>> I think that the modifier must be set when the key is pressed.
> >>>
> >>> TCHAR is useless, i'm working in ANSI, not UNICODE for windows.
> >>>
> >>> strcmp(*keyname, "") : **keyname == '\0'
> >>>
> >>> anyway, i'll have to check that
> >>>
> >>> thanks
> >>>
> >>> Vincent
> >>>
> >>>
> >>>
> ------------------------------------------------------------------------------
> >>> All the data continuously generated in your IT infrastructure
> >>> contains a definitive record of customers, application performance,
> >>> security threats, fraudulent activity, and more. Splunk takes this
> >>> data and makes sense of it. IT sense. And common sense.
> >>> http://p.sf.net/sfu/splunk-novd2d
> >>> _______________________________________________
> >>> enlightenment-devel mailing list
> >>> enl...@li...
> >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >>>
> >>
> >>
> >
>
>
> ------------------------------------------------------------------------------
> All the data continuously generated in your IT infrastructure
> contains a definitive record of customers, application performance,
> security threats, fraudulent activity, and more. Splunk takes this
> data and makes sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-novd2d
> _______________________________________________
> enlightenment-devel mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>