Re: [E-devel] [Patch] elm_slideshow patch

[PRINCE K. D. <pri...@sa...>]

Hi,

On behalf of Rajeev Ranjan, I am submitting the elm_slideshow patch which add support for getting notification when transition completes.
Change Log:
new signal “transition,end” has been introduced to get notification when transition completes.

Detail Description:
The actual requirement is to get user notified when the last item is visible in the slideshow. In this case, user wants to take some action, say updating button text to Restart if the slideshow does not have loop.
The current implementation of slideshow has a signal called “changed” which has current visible item as event_info parameter in the callback. User can compare it with the last appended item and come to know that the last item is visible if even_info is equal to the data passed which should be the last appended item. The only problem is that this signal is emitted by C code  asynchronously to the transition, hence if the transition involves an animation, user will most likely get it even before the transition completes. This may look bad to the user if the button label gets updated to Restart even before the last transition gets over.
In order to fulfill the requirement, I have introduced another signal “transition,end” which is emitted once the transition is over. 
The same requirement could have been fulfilled by emitting “changed” signal after the transition gets over but then this will be different from the existing implementation for other widgets, hence I introduced the new signal “transition,end”.

Please review it.
I'd appreciate any comments on this.

Thank you,
Prince