From: Vincent T. <vt...@un...> - 2011-11-06 06:37:03
|
changelog backport to 1.0 Vincent On Sat, 5 Nov 2011, Enlightenment SVN wrote: > Log: > From: Bluezery <oh...@gm...> > Subject: [E-devel] [ecore_file] Check a return value of > ecore_con_url_get() > > _ecore_file_download_curl() does not check return value of even if > ecore_con_url_get(), it can be failed. > I add a simple error checking. > Please review this patch. > > > > Author: raster > Date: 2011-11-05 23:14:31 -0700 (Sat, 05 Nov 2011) > New Revision: 64795 > Trac: http://trac.enlightenment.org/e/changeset/64795 > > Modified: > trunk/ecore/src/lib/ecore_file/ecore_file_download.c > > Modified: trunk/ecore/src/lib/ecore_file/ecore_file_download.c > =================================================================== > --- trunk/ecore/src/lib/ecore_file/ecore_file_download.c 2011-11-06 06:11:57 UTC (rev 64794) > +++ trunk/ecore/src/lib/ecore_file/ecore_file_download.c 2011-11-06 06:14:31 UTC (rev 64795) > @@ -369,7 +369,15 @@ > job->progress_cb = progress_cb; > _job_list = eina_list_append(_job_list, job); > > - ecore_con_url_get(job->url_con); > + if (!ecore_con_url_get(job->url_con)) > + { > + ecore_con_url_free(job->url_con); > + _job_list = eina_list_remove(_job_list, job); > + fclose(job->file); > + free(job->dst); > + free(job); > + return NULL; > + } > > return job; > } > > > ------------------------------------------------------------------------------ > RSA(R) Conference 2012 > Save $700 by Nov 18 > Register now > http://p.sf.net/sfu/rsa-sfdev2dev1 > _______________________________________________ > enlightenment-svn mailing list > enl...@li... > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > |