Re: [E-devel] [PATCH] Add ecore_imf_context_autocapital_type_{set, get}, ecore_imf_context_prediction_allow_{set, get}

[Jihoon K. <jih...@sa...>]

Thank you for your valuable comment.

I fixed the patch file and send again according to your advice.

Would you please review it again? :)

-----Original Message-----
From: Carsten Haitzler (The Rasterman) [mailto:ra...@ra...] 
Sent: Monday, April 25, 2011 5:15 PM
To: Jihoon Kim
Cc: enl...@li...; 박세환
Subject: Re: [E-devel] [PATCH] Add ecore_imf_context_autocapital_type_{set,
get}, ecore_imf_context_prediction_allow_{set, get}

On Wed, 20 Apr 2011 16:14:04 +0900 Jihoon Kim <jih...@sa...>
said:

> Hello, EFL developers.
> 
> To support the autocapitalization feature, I'd like to add
> ecore_imf_context_autocapital_type_{set,get} API.
> I will implement the autocapital feature in immodule, so the immodule
> should know the autocapitalization type.
> This API is for letting immodule know the autocapitalization type.
> 
> In addition, ecore_imf_context_prediction_allow_set API is used to set
> whether the IM context should allow to use the text prediction.
> 
> Would you please review this patch?

one comment?

+   Eina_Bool                      allow_prediction;

any reason u dont make it a bitfield? ie allow_prediction : 1
also why not put it at struct end to keep struct smaller? avoid alignment
padding issues.

-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ra...@ra...