Re: [E-devel] [PATCH] Patch to keep the cursor position regardless of changing edj

[Jihoon K. <jih...@sa...>]

1. The reason why I call edje_object_signal_emit is that _signal_cursor_changed function was not called in the below situation.

elm_entry_cursor_pos_set(en, 5);
elm_entry_password_set(en, EINA_TRUE);

2. The APIs such as elm_entry_password_mode_set, elm_entry_single_line_set call _elm_theme_object_set directly to change theme. 
Therefore, '_theme_hook' callback function has not been called.
As you mentioned it, there are a lot of redundant codes in each API.
I have fixed this problem and then attach the patch again.
Would you please review this patch again?

-----Original Message-----
From: Tom Hacohen [mailto:tom...@pa...] 
Sent: Thursday, March 17, 2011 1:29 AM
To: Jihoon Kim
Cc: enl...@li...
Subject: Re: [E-devel] [PATCH] Patch to keep the cursor position regardless of changing edj

Dear Jihoon,

Thanks a lot for the patch, I have one question and one comment:
Question: In line 89 of the patch, you added:
edje_object_message_signal_process(wd->ent);

Why is it needed there?

Comment:
I think all the 
+   elm_entry_cursor_pos_set(obj, wd->cursor_pos);
+   if (elm_widget_focus_get(obj))
+     edje_object_signal_emit(wd->ent, "elm,action,focus", "elm");

are not needed everywhere, but only in theme_hook. Does it work if you
remove it from everywhere except for theme_hook? if not, there's
probably something wrong that should be fixed, because this is what
theme_hook is for (updating the widget when the theme changes, among
others).

Thanks,
Tom.

On Wed, 2011-03-16 at 16:57 +0900, Jihoon Kim wrote:
> Hello.
> 
> Whenever the theme (edj) is changed in entry, the cursor position in entry
> is reset
> because elm_entry does not save the cursor position in the entry.
> 
> This patch is for keeping the cursor position in entry regardless of
> changing theme (edj).
> It will save the cursor position in entry and set the cursor position again
> after changing theme.
> 
> Would you please review this patch?
> 
> ------------------------------------------------------------------------------
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> _______________________________________________
> enlightenment-devel mailing list
> enl...@li...
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel