Re: [E-devel] Question about evas source code.

[Sebastian D. <sd...@ta...>]

Actually, someone fixed it correctly, then I "fixed" it wrongly :/

S.

On 02/19/2011 04:56 PM, Carsten Haitzler (The Rasterman) wrote:
> On Mon, 14 Feb 2011 14:02:47 +0200 Tom Hacohen
> <tom...@pa...>  said:
>
> actually someone "fixed" it and got it all wrong. it was JUST missing:
>
> dst = ret;
>
> before the loop. the way it was fixed means it will just crash somewhere else
> as it returns the LAST value ret had once looping and incrementing it to the
> end.
>
>> Ha, you didn't paste that part before.
>>
>> Yeah, should probably be ret, kill this dst thingie :)
>>
>> --
>> Tom.
>>
>> On Mon, 2011-02-14 at 11:54 +0000, ChunEon Park wrote:
>>> Thanks Tom.
>>>
>>> But  I have one more question about the second.
>>>
>>> It looks that it uses dst without  allocating anything.
>>>
>>> Doesn't it?
>>>
>>> And why it  execute this line ?
>>>   *dst = CONVERT_ARGB_8888_TO_A_8(*src);  //Ok, This can be done.
>>>
>>> even dst never refered by anywhere...
>>>
>>> It seems that dst should be changed to ret.
>>>
>>> How do you think about this?
>>> -------------------------------------------------------------------------------------------------------------------
>>> //evas/src/lib/engines/common/evas_convert_colorspace.c
>>> static inline void *
>>> evas_common_convert_argb8888_to_a8(void *data, int w, int h, int stride,
>>> Eina_Bool has_alpha)
>>> {
>>>     uint32_t *src, *end;
>>>     uint8_t *ret, *dst;
>>>
>>>     src = data;
>>>     end = src + (stride * h);
>>>     ret = malloc(w * h);
>>>
>>>     if (!has_alpha)
>>>       {
>>>          return memset(ret,0xff, w * h);
>>>       }
>>>
>>>     for ( ; src<  end ; src ++, dst ++)  // what does dst++ purpose for ?
>>>        *dst = CONVERT_ARGB_8888_TO_A_8(*src);  //Ok, This can be done.
>>>     return ret;
>>> }
>>>
>>>
>>>
>>>
>>>
>>> ------- Original Message -------
>>> Sender : Tom Hacohen<tom...@pa...>  Engineer/STRI-SLP RTL
>>> Language supporting/???? Date : 2011-02-14 20:32 (GMT+09:00)
>>> Title : Re: [E-devel] Question about evas source code.
>>>
>>> Hey Hermet,
>>>
>>>>     if ((p[i] == '-') || (m == 256))      // 256 ?
>>>>       {
>>>>          dest[n][m] = 0;              // If the m is 256 then it will be
>>>> out of boundary.
>>>>                                       // Or if the m will never be more
>>>> than 256, then we don't need to compare "m == 256"
>>> Looks like either a typo, or just someone overlooking something, no idea
>>> really.
>>>
>>>> ----------------------------------------------------------------------------
>>>> ------------------------------------------
>>>> Second is here. It's not critical but looks strange.
>>>>     for ( ; src<  end ; src ++, dst ++)  // what does dst++ purpose for ?
>>>>        *dst = CONVERT_ARGB_8888_TO_A_8(*src);  //Ok, This can be done.
>>>
>>> This is actually pretty common in the C world. It advances both the src
>>> and the dst by one each time and thus copying all the cells of the array
>>> one by one.
>>>
>>> --
>>> Tom.
>>
>>
>>
>> ------------------------------------------------------------------------------
>> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
>> Pinpoint memory and threading errors before they happen.
>> Find and fix more than 250 security defects in the development cycle.
>> Locate bottlenecks in serial and parallel code that limit performance.
>> http://p.sf.net/sfu/intel-dev2devfeb
>> _______________________________________________
>> enlightenment-devel mailing list
>> enl...@li...
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>
>