From: Daniel J. S. <seo...@gm...> - 2010-12-20 05:52:49
|
Hello, How about using below names for smart callbacks? "multi,swipe,left" - Genlist has been multi-touch swept left. "multi,swipe,right" - Genlist has been multi-touch swept right. "multi,swipe,up" - Genlist has been multi-touch swept top. "multi,swpie,down" - Genlist has been multi-touch swept bottom. "multi,pinch,out" - Genlist has been multi-touch pinched out. "multi,pinch,in" - Genlist has been multi-touch pinched in. Because there is a "swipe" smart callbacks, I think we can use the name "swipe" here too. And Mr. Yun, can you add doxygen for those events as well? Please add smart callback doxygen to elm_genlist.c. You can see existing doxygens at the top of elm_genlist.c So you may add "multi,**" doxygens around line number 78~80. Thank you. Daniel Juyung Seo (SeoZ) On Fri, Dec 17, 2010 at 5:28 PM, Jeonghyun Yun <jh0...@sa...> wrote: > Dear SeoZ, > > Yes. I agree about using up & down instead of top & bottom. > > And I'm also not sure but 'sweep' is not bad. > Also 'move' is a good name. Then how about 'dragged'? > > I don't know well. Anybody please suggest a good name. > > Thanks. > > -----Original Message----- > From: Daniel Juyung Seo [mailto:seo...@gm...] > Sent: Friday, December 17, 2010 4:40 PM > To: Jeonghyun Yun > Cc: enl...@li... > Subject: Re: [E-devel] [Patch] elm_genlist multi-touch smart callbacks added > > Dear Yun, > > How about renaming some callbacks? > "multi,sweep,top" => "multi,sweep,up" > "multi,sweep,bottom" => "multi,sweep,down" > Multi touch event cares only for the touch behavior not the callback's > behavior. > > And I'm not sure it is ok to use the word 'sweep'. > Anybody please suggest a good name for this. Maybe 'move'? > I'm not sure about this. > > Anyway thanks for your effort. > Daniel Juyung Seo. (SeoZ) > > > On Fri, Dec 17, 2010 at 11:48 AM, Jeonghyun Yun <jh0...@sa...> > wrote: >> Dear all, >> >> I added 6 multi-touch smart callbacks in elm_genlist, please refer to > below. >> >> "multi,sweep,left" - Genlist has been multi-touch swept left. >> "multi,sweep,right" - Genlist has been multi-touch swept right. >> "multi,sweep,top" - Genlist has been multi-touch swept top. >> "multi,sweep,bottom" - Genlist has been multi-touch swept bottom. >> "multi,pinch,out" - Genlist has been multi-touch pinched out. >> "multi,pinch,in" - Genlist has been multi-touch pinched in. >> >> I think these smart callbacks are very useful for elm_genlist multi-touch >> effect. >> >> If this patch have any issue, please let me know. >> >> Thanks. >> >> > ---------------------------------------------------------------------------- > -- >> Lotusphere 2011 >> Register now for Lotusphere 2011 and learn how >> to connect the dots, take your collaborative environment >> to the next level, and enter the era of Social Business. >> http://p.sf.net/sfu/lotusphere-d2d >> _______________________________________________ >> enlightenment-devel mailing list >> enl...@li... >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> > > |