From: Enlightenment S. <no-...@en...> - 2010-11-14 02:25:51
|
Log: From: Nikolas Arend <Nik...@gm...> Attached patch for e_dbus seems to fix this particular issue with _places_volume_properties_cb() for me, but I'm not sure if the root of the problem is somewhere else, since I'm getting other occasional segfaults now caused by different parts the code. I'll try to look into it or provide a bt. Author: raster Date: 2010-11-13 18:25:45 -0800 (Sat, 13 Nov 2010) New Revision: 54545 Modified: trunk/e_dbus/src/lib/hal/e_hal_util.c Modified: trunk/e_dbus/src/lib/hal/e_hal_util.c =================================================================== --- trunk/e_dbus/src/lib/hal/e_hal_util.c 2010-11-14 02:20:57 UTC (rev 54544) +++ trunk/e_dbus/src/lib/hal/e_hal_util.c 2010-11-14 02:25:45 UTC (rev 54545) @@ -33,6 +33,7 @@ E_Hal_Property *prop; if (err) *err = 0; if (!properties->properties) return NULL; + if (!key) return NULL; prop = eina_hash_find(properties->properties, key); if (prop) return prop->val.s; @@ -46,6 +47,7 @@ E_Hal_Property *prop; if (err) *err = 0; if (!properties->properties) return EINA_FALSE; + if (!key) return EINA_FALSE; prop = eina_hash_find(properties->properties, key); if (prop) return prop->val.b; @@ -59,6 +61,7 @@ E_Hal_Property *prop; if (err) *err = 0; if (!properties->properties) return 0; + if (!key) return 0; prop = eina_hash_find(properties->properties, key); if (prop) return prop->val.i; @@ -72,6 +75,7 @@ E_Hal_Property *prop; if (err) *err = 0; if (!properties->properties) return 0; + if (!key) return 0; prop = eina_hash_find(properties->properties, key); if (prop) return prop->val.u64; @@ -85,6 +89,7 @@ E_Hal_Property *prop; if (err) *err = 0; if (!properties->properties) return 0; + if (!key) return 0; prop = eina_hash_find(properties->properties, key); if (prop) return prop->val.d; @@ -98,6 +103,7 @@ E_Hal_Property *prop; if (err) *err = 0; if (!properties->properties) return NULL; + if (!key) return NULL; prop = eina_hash_find(properties->properties, key); if (prop) return prop->val.strlist; |