Re: [E-devel] E SVN: jeffdameth trunk/eterm/Eterm/src

[Kim W. <ki...@wo...>]

On Tue, 06 Oct 2009 22:27:38 +0200, Michael Jennings <me...@ka...> wrote:

> On Tuesday, 06 October 2009, at 21:52:42 (+0200),
> Kim Woelders wrote:
>
>> It seems to me that you are making Eterm e17 compliant in stead of  
>> making
>> e17 MWM hint compliant.
>
> I think he did that too.  My thought was to make Eterm more EWMH
> compliant.  Do you feel that this patch fails to accomplish that?
>
In my opinion the MWM hint is not related to EWMH, so I think all that is  
accomplished is to fetch a potentially rather large atom list which  
shouldn't contain the item being looked for :)

This may just be my opinion though. AFAIK this is not covered specifically  
by standards and I don't know what other WMs do.
I just find it reasonable that if you test for MWM compliance, you look  
for _MOTIF_WM_INFO, not _NET_SUPPORTED.
If a WM wants to honor MWM_HINTS_DECORATIONS for old apps it most likely  
has _MOTIF_WM_INFO set anyway.

>> I don't think _MOTIF_WM_HINTS should be listed in _NET_SUPPORTED at
>> all.  It just makes no sense. EWMH unaware apps will certainly never
>> look there.
>
> It doesn't seem to me that this would break anything, though (speaking
> specifically about the Eterm patch, not what should/shouldn't be done
> to E).
>
No, no breakage, just overhead.

>> If anything should be changed here, I'd consider removing the test
>> for _MOTIF_WM_INFO (and going override-redirect if not set) and just
>> set the MWM hint if borderless is requested.
>
> What are your thoughts on why you'd go this route as opposed to
> supporting the additional netwm-based mechanism?
>
This would just set the MWM hint and hope for the best. If the WM handles  
it, fine (is there any WM around that doesn't?). If not, you'd just get  
your non-borderless window. I think it is really bad client behavior to  
resort to override-redirect. It seems to me that it doesn't and can't work  
properly anyway due to focus issues.

> The patch seemed reasonable to me (Hannes had me review it before he
> committed), but I'm open to other suggestions as well.
>

/Kim