From: Gustavo S. B. <bar...@pr...> - 2009-09-01 10:27:24
|
On Tue, Sep 1, 2009 at 6:15 AM, Cedric BAIL<ced...@fr...> wrote: > On Tue, Sep 1, 2009 at 12:22 AM, Gustavo Sverzut > Barbieri<bar...@pr...> wrote: >> - fixing bugs reported by Luis Felipe's LLVM/Clang: >> http://local.profusion.mobi:8081/~lfelipe/output-efl/ >> - moving code from fprintf/printf to eina_log (prefer to do this >> BEFORE this weekend!) > > eina_log should also be used more inside eina, I don't know if André > Dieb plan to do it, but you can do a file by file hunt of eina_error > and replace it with eina_log. Perhaps André you can do one small > commit so others can understand what needs to be done. Sure, and this all should use log domains. At least each library and E17 split into core and per module should have it. For those used to ecore_event_type_new(), it's pretty similar! We made it on purpose. The recommended usage is to register the new domain on first MODULE_init() and unregister on last MODULE_shutdown(), then define macros in your MODULE_private.h: extern int _MODULE_log_dom = -1; /* usually not static since multiple .o will use the same domain */ #define DBG(...) EINA_LOG_DOM_DBG(_MODULE_log_dom, __VA_ARGS__) #define ERR(...) EINA_LOG_DOM_ERR(_MODULE_log_dom, __VA_ARGS__) for E17 i guess we can have E_DBG, E_ERR... so users can use the simple versions themselves. OR simply modules could #undef and define it again in their own header/source. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: bar...@gm... Skype: gsbarbieri Mobile: +55 (19) 9225-2202 |