Re: [E-devel] [PATCH] ecore aborts on EBADF

[Christopher M. <cpm...@co...>]

Marco Trevisan (Treviño) wrote:
> Carsten Haitzler (The Rasterman) wrote:
>> On Sat, 18 Apr 2009 01:01:00 +0200 "Marco Trevisan (Treviño)" <ma...@3v...>
>> said:
>>
>>> Andre Dieb wrote:
>>>> Here's a patch for handling EBADF (Bad file descriptor) error after select()
>>>> (following the thread "random abort caused by ecore").
>>>>
>>>> It uses fcntl() for finding which fd raises EBADF. I tested the patch with
>>>> the attached program (somehow dirty but maybe shows the patch works).
>>>>
>>>> Please mail me with any suggestions.
>>> The patch seems ok, but are really needed all those "fprintf(stderr, ."?
>>> I guess they were there just for debugging... Please could someone
>>> remove them from upstream? :P
>> for now i'd like to keep them so we know whats going on runtime... :)
> 
> Ah... Ok, but I thought that at least the one in
> _ecore_main_fd_handlers_cleanup() is flooding too match to be useful
> (using some ecore_con based functions, I've experienced that).
> 
I've experienced the same thing myself lately and it is quite annoying 
as it floods my own apps printfs right off of the terminal :( so I 
removed one in the main_fd_handlers_cleanup function. It's still there, 
just commented out. For reference, it was the printf that would printf 
which fd was getting removed.

dh