E SVN: kwo trunk/E16/e/src

[Enlightenment S. <no-...@en...>]

Log:
  A bit more consistent naming and minor tweaks (groups).
Author:       kwo
Date:         2008-10-18 09:13:54 -0700 (Sat, 18 Oct 2008)
New Revision: 36787

Modified:
  trunk/E16/e/src/groups.c trunk/E16/e/src/groups.h trunk/E16/e/src/snaps.c 

Modified: trunk/E16/e/src/groups.c
===================================================================
--- trunk/E16/e/src/groups.c	2008-10-18 16:10:36 UTC (rev 36786)
+++ trunk/E16/e/src/groups.c	2008-10-18 16:13:54 UTC (rev 36787)
@@ -196,7 +196,14 @@
    return (Group **) ecore_list_items_get(group_list, pnum);
 }
 
-Group             **
+Group              *const *
+EwinGetGroups(const EWin * ewin, int *num)
+{
+   *num = ewin->num_groups;
+   return ewin->groups;
+}
+
+static Group      **
 ListWinGroups(const EWin * ewin, char group_select, int *num)
 {
    Group             **groups = NULL;
@@ -361,7 +368,7 @@
 		ewin->groups =
 		   EREALLOC(Group *, ewin->groups, ewin->num_groups);
 
-	     SaveGroups();
+	     GroupsSave();
 	     return;
 	  }
      }
@@ -487,7 +494,7 @@
      }
    if (group_index < 0)
       Efree(gwins);
-   SaveGroups();
+   GroupsSave();
 }
 #else
 
@@ -496,7 +503,7 @@
 #endif /* USE_GROUP_SHOWHIDE */
 
 void
-SaveGroups(void)
+GroupsSave(void)
 {
    Group              *g;
    FILE               *f;
@@ -538,7 +545,7 @@
    fclose(f);
 }
 
-static void
+void
 GroupsLoad(void)
 {
    FILE               *f;
@@ -647,7 +654,7 @@
 	Efree(tmp_groups);
 	tmp_groups = NULL;
 
-	SaveGroups();
+	GroupsSave();
      }
 }
 
@@ -1081,17 +1088,6 @@
 }
 
 static void
-GroupsSighan(int sig, void *prm __UNUSED__)
-{
-   switch (sig)
-     {
-     case ESIGNAL_INIT:
-	GroupsLoad();
-	break;
-     }
-}
-
-static void
 GroupShow(Group * g)
 {
    int                 j;
@@ -1197,7 +1193,7 @@
 	IpcPrintf("Error: no such operation: %s", operation);
 	return;
      }
-   SaveGroups();
+   GroupsSave();
 }
 
 static void
@@ -1408,7 +1404,7 @@
 extern const EModule ModGroups;
 const EModule       ModGroups = {
    "groups", "grp",
-   GroupsSighan,
+   NULL,
    {N_IPC_FUNCS, GroupsIpcArray},
    {N_CFG_ITEMS, GroupsCfgItems}
 };

Modified: trunk/E16/e/src/groups.h
===================================================================
--- trunk/E16/e/src/groups.h	2008-10-18 16:10:36 UTC (rev 36786)
+++ trunk/E16/e/src/groups.h	2008-10-18 16:13:54 UTC (rev 36787)
@@ -63,13 +63,13 @@
 					       char nogroup, int *num);
 
 /* groups.c */
+Group              *const *EwinGetGroups(const EWin * ewin, int *num);
 Group              *EwinsInGroup(const EWin * ewin1, const EWin * ewin2);
 void                GroupsEwinAdd(EWin * ewin, int gid);
 void                GroupsEwinRemove(EWin * ewin);
-void                SaveGroups(void);
+void                GroupsLoad(void);
+void                GroupsSave(void);
 Group             **GroupsGetList(int *pnum);
-Group             **ListWinGroups(const EWin * ewin, char group_select,
-				  int *num);
 int                 GroupsGetSwapmove(void);
 
 #endif /* _GROUPS_H_ */

Modified: trunk/E16/e/src/snaps.c
===================================================================
--- trunk/E16/e/src/snaps.c	2008-10-18 16:10:36 UTC (rev 36786)
+++ trunk/E16/e/src/snaps.c	2008-10-18 16:13:54 UTC (rev 36787)
@@ -389,7 +389,7 @@
 _SnapUpdateEwinGroups(Snapshot * sn, const EWin * ewin, char onoff)
 {
    EWin              **gwins = NULL;
-   Group             **groups;
+   Group              *const *groups;
    int                 i, j, num, num_groups;
 
    if (!ewin)
@@ -409,8 +409,7 @@
      {
 	if (onoff)
 	  {
-	     groups =
-		ListWinGroups(gwins[i], GROUP_SELECT_EWIN_ONLY, &num_groups);
+	     groups = EwinGetGroups(gwins[i], &num_groups);
 	     if (groups)
 	       {
 		  sn = gwins[i]->snap;
@@ -418,15 +417,13 @@
 		     sn = _SnapEwinGet(gwins[i], SNAP_MATCH_DEFAULT);
 		  if (sn)
 		    {
+		       sn->num_groups = num_groups;
 		       Efree(sn->groups);
 		       sn->groups = EMALLOC(int, num_groups);
 
-		       sn->num_groups = num_groups;
-
 		       for (j = 0; j < num_groups; j++)
 			  sn->groups[j] = groups[j]->index;
 		    }
-		  Efree(groups);
 	       }
 	  }
 	else
@@ -1167,7 +1164,7 @@
    if (!isfile(buf))
       Alert(_("Error saving snaps file\n"));
 
-   SaveGroups();
+   GroupsSave();
 
  done:
    TIMER_DEL(ss_timer);
@@ -1199,6 +1196,8 @@
    FILE               *f;
    int                 res_w, res_h, a, b, c, d;
 
+   GroupsLoad();
+
    Esnprintf(buf, sizeof(buf), "%s.snapshots", EGetSavePrefix());
    f = fopen(buf, "r");
    if (!f)