Re: [E-devel] E CVS: apps/e morlenxus

[Christopher M. <cpm...@co...>]

Brian 'morlenxus' Miculcy wrote:
> On Fri, May 23, 2008 at 12:48:04AM -0500, Alberto Castro wrote:
>>>
>>> Log Message:
>>> Better sorted border menu.
>>>
> <snip>
>> This is good, although "More.." is usually reserved as the last entry on  
>> a list/menu. Moving on, the contents of the window "border" menu have  
>> shifted quite a lot (pixels) due to this commit, as seen here:
>>
>> http://cored.org/tmp/border_menu_shift.png
>>
>> No longer is there padding between the submenu and the main menu (arrows).
>>
>> As oppose to what they normally look like under the main menu:
>> http://cored.org/tmp/main_menu_.png
>>
>> Regards
> 
> Well i might put the more... entry at the last item of that menu, any
> other oppinions?

I don't think More would be too good at the bottom of the menu due to 
the dynamic nature of the menu position. IE: if you have a window at the 
bottom of the screen and you open the menu with "More" at the bottom, 
then that would be the first entry that would get selected from a mouse 
movement..and odds are what the average user is looking for would not be 
in the More menu anyway.

> I noticed that menu shifted pixels problems too - no clue why that
> happens. Anyone?
> 
A reordering of the menu should not have caused this...after all, a menu 
is still a menu as far as edje is concerned. I looked at the new 
ordering code and didn't see anything in there that would be causing 
this, but will take another look. Perhaps some other commit broke the menu ?

dh