Re: [E-devel] Lock dialog and ibar patch

[Osei P. <op...@ec...>]

On 06/07/22 at 13:26 +0200, Morten Nilsen wrote:
> Osei Poku wrote:
> >  	cfdata->border->lock_client_maximize = 1;
> >  	cfdata->border->lock_client_fullscreen = 1;
> >       }
> > +   else
> > +     {
> > +	cfdata->border->lock_client_location = 0;
> > +	cfdata->border->lock_client_size = 0;
> > +	cfdata->border->lock_client_stacking = 0;
> > +	cfdata->border->lock_client_iconify = 0;
> > +	cfdata->border->lock_client_desk = 0;
> > +	cfdata->border->lock_client_sticky = 0;
> > +	cfdata->border->lock_client_shade = 0;
> > +	cfdata->border->lock_client_maximize = 0;
> > +	cfdata->border->lock_client_fullscreen = 0;
> > +     }
> 
> don't know about you, but I like to eliminate duplicate code..
> 
> so, to me, it seems it would be better to use an intermittent variable..
> 
> val = (foo) ? 1 : 0;
> 
> .... = val;
> .... = val;
> ......
> 
> val = (bar) ? 1 : 0;
> 
> etc..
> 
> -- 
> Cheers,
> Morten
> :wq

Good call. Changes made.  The lock_client_desk field doesnt seem to be
used and so I leave it unchanged.

Osei