RE: [E-devel] Re: Patch submission for EWL

[dan s. <ze...@pe...>]

I really don't think doing this with a linear search of the array every time is a good idea. If you have a big directory it will take a lot of work to get it sorted. Especially on osx where it will have to walk the entire list everytime to find where to insert the item (which, on osx just ends up being the end).

You should change this to a smarter insertion algorition. Something like a binary search to find the position would be faster and take looking at less nodes. This has to be _fast_ and it has to be fast on large directories as it will get run a lot.

dan



> Resubmitting with 'cvs diff -u' per Raster's instructions.
> 
> 
> On 7/7/05, Ed Stafford <ed....@gm...> wrote:
> > 
> > Hey folks. Here is a patch for ewl_fileselector.c that will alpha sort the 
> > files and dir listings in the selector box. Appearently, if you're on OS X, 
> > the lists are already sorted, but on x86 Linux, that's not the case.
> > 
> > I built the patch with 'cvs diff ewl_fileselector.c' If you'd like it 
> > built a different way, submitted another way, etc., please let me know so I 
> > can do it right.
> > 
> > Thanks.
> > Dysath
> > 
> >
>