From: Till A. <ti...@ad...> - 2002-02-25 13:06:04
|
# Quoting Christian Kreibich (kre...@in...): > Yeah, me, and I agree that it's good work. Till has implemented > basically exactly what was suggested on the list. Had a bit of a chat > with Till lately, and we agreed that the view model should have explicit > knowledge of the list of files a directory contains (stored as a > hashtable) to minimize Efsd communication. When that's there, we should > have a good basis and a nice design for multiple views. Ok guys and girls (and boris), if nobody minds I'd like to commit what I have now, because I think the remaining issues can be fixed quicker in cooperation. Everything else is done, including the E_File/E_Icon separation and the list of files in the view model. A todo off the top of my head: - icon_move_cb is currently #if 0'd because frankly its a mess. Maybe whoever wrote that can help me clean it up and make dnd work again. :) - metadata handling is disabled. I still think there's the need for discussion here. Do we really want to save _every_ damned icon's coordinates? When should we save? On view close? - iconbar handling needs to be improved (but will be rewritten, so I made it work reasonably and stopped there. dnd is broken) - epplets I have not even looked at - the list of files in a dir is still a list. This would better be an ewd_hash, as discussed. - the sucker probably leaks all over the place - currently the dirty flag (view->changed) is ignored and all views are redrawn by the idle handler. Proper setting of this flag is obviously needed. We need to hunt down all places where a redraw is really needed. There's probably more because I needed to touch quite a bit of code to get this done right. Obviously this means some regression, features that were there are temporarily broken, but we're in alpha, so what the hell and I think its worth it. :) If you want another patch to look at, shout. Cheers, Till |