Re: imlib2 stuff [ was [E-devel] imlib2 bug ]

[Carsten H. (T. R. <ra...@ra...>]

On Sun, 12 Aug 2001 13:54:22 +0100 Tom Gilbert <to...@li...> babbled
profusely:

> * Carsten Haitzler (ra...@ra...) wrote:
> > On Sat, 11 Aug 2001 23:32:15 -0700 Michael Jennings <me...@en...>
> > babbled profusely:
> > 
> > > 
> > > To that end, I'd like to make a suggestion.  raster, take a break,
> > > have a few beers, and play some AO.  Tom, go ahead and make your
> > > proposed 15-line change in CVS and commit it.  Once you've done this,
> > 
> > its actually not a 15 line change - the file chanckign needs to nwo go into
> each
> > loader because imlib2 does file checking before it calls a loader... this
> needs
> > to go and be put into the loaders and then they need to be able to report
> back
> > these errors... :) anyway.... thats what i said in that paragraph outlining
> how
> > it would work if it were implimented. the db loader woudl just do slightly
> > different checking.
> 
> Raster. Why aren't you listening to me. No the file checking does not go
> in the loaders. That was one of my suggestions but as I've said a
> million times now that's not the one I want to do.

   if ((im) && (IMAGE_IS_VALID(im)))
   {
      if (IMAGE_ALWAYS_CHECK_DISK(im))
      {
         time_t current_modified_time;

         current_modified_time = __imlib_FileModDate(file, raw_file_mode);
         /* if the file on disk is newer than the cached one */
         if (current_modified_time > im->moddate)
         {
            /* invalidate image */
            SET_FLAG(im->flags, F_INVALID);
         }
         else
         {
            /* image is ok to re-use - program is just being stupid loading */
            /* the same data twice */
            im->references++;
            return im;
         }
      }
...
its checkign modified dates....
...
im->moddate = __imlib_FileModDate(file, raw_file_mode);
...
its getting modified dates...

this wont work if we dont split the filename...

this needs to be deferred to the loaders...

> You obviously can't understand this, so I'm going to make the change.
> 
> Tom.
> -- 
>    .^.    .-------------------------------------------------------.
>    /V\    | Tom Gilbert, London, England | http://linuxbrit.co.uk |
>  /(   )\  | Open Source/UNIX consultant  | to...@li...    |
>   ^^-^^   `-------------------------------------------------------'
> 
> _______________________________________________
> Enlightenment-devel mailing list
> Enl...@li...
> http://lists.sourceforge.net/lists/listinfo/enlightenment-devel


-- 
--------------- Codito, ergo sum - "I code, therefore I am" --------------------
The Rasterman (Carsten Haitzler)    ra...@ra...     ra...@va...
VA Linux Systems                    ra...@de...
Mobile Phone: +61 (0)408 363 984    Work Phone: +61 (02) 9386 9362