Menu

#363 Per-recipient rule with "possible" encryption causes unencrypted mails despite displayed otherwise

fixed
nobody
None
1.7.2
Major
31.2.0
2.0.25
Linux
1.8.0
nobody
2014-12-13
2014-11-08
No

With Enigmail 1.7 the default behavior is now "do encrypt if key is available".

However, if a per-recipient rule exists, which sets the default encryption behavior for the given recipient to "Yes, if selected in Message Composition", this isn't true anymore:

In the message composition window, once such a recipient is inserted in the "To" field, the enigmail toolbar dropdown menu states "Message will be encrypted" - the same as if there wasn't a per-recipient rule.

However the mail will be sent out unencrypted!

I'd consider that bug rather severe, because users assume their emails would be encrypted, but actually aren't.

Discussion

  • Ludwig Hügelschäfer

    How are your preferences set? Are you using "Manual encryption"or "Convenient Encryption"? If manual is used, how did you set the further options?

    How did you set the account specific options (especially "Encrypt by default")?

     
  • Foobar

    Foobar - 2014-11-17

    I have the same problem, with version number 2.0.26 for GnuPG and the same version numbers for Enigmail and Thunderbard as TO posted.

    In Enigmail preferences in the "Send" tab, I have configured:
    "Manual Encryption"
    "Encrypt/sign replies to encrypted/signed messages"
    "Automatically send encrypted" - "If possible"
    "To send encrypted, accept" - "All valid keys I have"

    The setting of "Confirm before sending" was on "Always" and on "If rules changed the default encryption setting" during tests, but nothing indicated that the mail will be sent unencrypted, and the behaviour regarding encryption didn't change.

    I hope for a quick fix because today I sent a list of passwords unencrypted due to this bug and I don't want that to happen to other people. (Luckily, password change in order to prevent damage is possible in this case.)

    Addendum: "Encrypt messages by default" for this account is ticked off.

     

    Last edit: Foobar 2014-11-17
  • Nicolas Dietrich

    I'm using "convenient encryption".

    For the account settings:

    • No: Encrypt messages by default
    • No: Sign messages by default
    • Yes: Use PGP/MIME by default

    (after application of defaults and rules)

    • Yes: sign non-encrypted messages
    • Yes: sign encrypted messages
    • Yes: Encrypt draft messages on saving
     

    Last edit: Nicolas Dietrich 2014-11-22
  • Nicolas Dietrich

    Is there anything more I can do (apart from coding) to speed up the resolution of this bug, e.g. donate? This is massively undermining trust in enigmail for me and hopefully not for too many others. Due to the UI changes, this is a bad regression in 1.7 which needs to be fixed ASAP!

     

    Last edit: Nicolas Dietrich 2014-12-09
  • Patrick Brunschwig

    Could you try a current nightly build?

     
  • Nicolas Dietrich

    I'll do as soon as I find the time and the build.

    Update: Nightly build is here.

     

    Last edit: Nicolas Dietrich 2014-12-09
  • Nicolas Dietrich

    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -6,4 +6,4 @@
    
     However the mail will be sent out unencrypted!
    
    -I'd consider that bug rather severe, because users assume there emails will be encrypted, but actually aren't.
    +I'd consider that bug rather severe, because users assume their emails would be encrypted, but actually aren't.
    
     
  • Nicolas Dietrich

    Yep, fixed in current nightly! Wording and UI is also better now!

    Will donate a few € now :)

    Unfortunately (but not related to this bug) I noticed that encryption now isn't on by default anymore, in contrast to the 1.7 behavior. That's sad. (Or something has changed which I didn't understand, or I thought something wrong. Don't have time to investigate any further. Will file a separate bug if I find the time.)

     
  • Ludwig Hügelschäfer

    • status: open --> fixed
     
  • Patrick Brunschwig

    • status: fixed --> open
     
  • Patrick Brunschwig

    In the following situation the message does get encrypted, but there is no indication on the GUI that the message will be encrypted:

    • Convenient Defaults, no default encryption activated
    • rule set up: specific key selected; "yes if selected" chosen for all 3 parameters

    If a message is sent to an email address not on the keyring, but for which above rule leads to a valid key, then above behavior can be observed

     
  • Patrick Brunschwig

    • status: open --> fixed
    • Fixed in version: --- --> 1.8.0
     
  • Patrick Brunschwig

    fixed on master.

     

Log in to post a comment.

MongoDB Logo MongoDB