Menu

#164 XMLFileManipulator's loopWrite method is very inefficient

closed-fixed
None
6
2008-05-09
2008-05-09
No

There is an excessive amount of string concatenation being performed in this method. Java strings are immutable. Every call to += or + will instantiate a new StringBuffer with the appropriate 'append' method being called. This is horribly inefficient. The method should be altered to use a StringBuffer instead.

Discussion

  • Remy Chi Jian Suen

    • assigned_to: nobody --> rcjsuen
    • status: open --> closed-fixed
     
  • Remy Chi Jian Suen

    Logged In: YES
    user_id=1299552
    Originator: YES

    Fix released to HEAD.

     

Log in to post a comment.

Auth0 Logo