Menu

#130 Methods missing in Outline

closed-fixed
None
5
2008-01-31
2008-01-21
No

If the attached file is opened in the editor, the Outline view does not show all methods of class StyleCLI.

More precisely, "FormatProperty(...)" is the last method shown, and methods from "FormatEvent(...)" are missing. These are 7 methods total.

Likely, this bug is caused by the parser.

Discussion

  • Harald Krapfenbauer

    The file where this bug happens.

     
  • Remy Chi Jian Suen

    Logged In: YES
    user_id=1299552
    Originator: NO

    Test case below will illustrate the problem:
    class ErrorClass
    {
    void X()
    {
    StringBuilder sb = new StringBuilder ();
    sb.Append("{");
    sb.Append("set;");
    sb.Append("};\n");
    return sb.ToString ();
    }

    void V()
    {
    }
    }

     
  • Remy Chi Jian Suen

    Logged In: YES
    user_id=1299552
    Originator: NO

    Thanks for the report, Harald. This has been fixed in CVS HEAD. Please verify.

     
  • Remy Chi Jian Suen

    • assigned_to: nobody --> rcjsuen
    • status: open --> closed-fixed
     
  • Harald Krapfenbauer

    • status: closed-fixed --> open-fixed
     
  • Harald Krapfenbauer

    Logged In: YES
    user_id=1736779
    Originator: YES

    Verified!

     
  • Harald Krapfenbauer

    • status: open-fixed --> closed-fixed
     
  • Harald Krapfenbauer

     
  • Harald Krapfenbauer

    • status: closed-fixed --> open
     
  • Harald Krapfenbauer

    Logged In: YES
    user_id=1736779
    Originator: YES

    I'm sorry, I have to re-open this bug.
    The newly attached file "Expression.cs" cannot be scanned either. Same problem: Most of the source code is not parsed, starting at method DoParse(...).

    File Added: Expression.cs

     
  • Harald Krapfenbauer

    Logged In: YES
    user_id=1736779
    Originator: YES

    Ad last comment: Actually, this was wrong and due to bug #1878266.
    However, the parser skips several items.

     
  • Remy Chi Jian Suen

    Logged In: YES
    user_id=1299552
    Originator: NO

    I've identified that the failure in Expression.cs is due to the fix that was implemented for the original problem. I have a proposed workaround but then the speed that it takes to parse a file seems to double in length. Will investigate further.

     
  • Remy Chi Jian Suen

    Logged In: YES
    user_id=1299552
    Originator: NO

    Here are some trial runs I did before and after the fix, times are in milliseconds.

    Before:
    433
    628
    384
    425
    393
    470
    410
    427
    412
    489

    After:
    958
    1003
    916
    1008
    929
    1024
    999
    1126

     
  • Remy Chi Jian Suen

    Logged In: YES
    user_id=1299552
    Originator: NO

    I've committed some changes to get the members showing but the hierarchical structure is currently off.

     
  • Remy Chi Jian Suen

    Logged In: YES
    user_id=1299552
    Originator: NO

    Actually, this file is more complicated than I thought, there are still other things that aren't being parsed properly.

     
  • Remy Chi Jian Suen

    • status: open --> closed-fixed
     
  • Remy Chi Jian Suen

    Logged In: YES
    user_id=1299552
    Originator: NO

    Expression.cs should be fine now.

     

Log in to post a comment.

Auth0 Logo