|
From: Luca T. <no...@gi...> - 2026-10-14 12:02:28
|
Branch: refs/heads/master Home: https://github.com/LinuxCNC/linuxcnc Commit: f6ff60787b8cd88133b8b96143894e16e20c5e66 https://github.com/LinuxCNC/linuxcnc/commit/f6ff60787b8cd88133b8b96143894e16e20c5e66 Author: Luca Toniolo <107...@us...> Date: 2026-10-14 (Wed, 14 Oct 2026) Changed paths: M src/emc/rs274ngc/gcode_renderer.cc M src/emc/rs274ngc/gcode_renderer.hh M tests/glcanon/test_workplane.py Log Message: ----------- preview: a cut from where left-out traverses went counts toward the plane After G43 or a tool change the preview leaves out the traverses before the first feed, as it always has, and those traverses never reached the plane in effect either. A plane whose first cut starts from them recorded only the cut's end: Sigma1912's program, G68.2, G53.1, G0 X0 Y0 Z50, G0 Z0, G1 X600, drew the first plane small at X 600 instead of over the cut from X 0 to 600. A traverse left out under a plane now marks the point it reached, and a cut drawn from that point counts its start toward the plane. Only then: counting every left-out traverse would take in the end of a G53.1 orientation move, where the tool stood before the plane, and counting every cut's start would take in a cut that begins before the plane is set. tests/glcanon/test_workplane.py checks a cut after G43.1 drawn from where the traverses went. Reported by Sigma1912. Commit: f6eea6847fe42f70ef877cd6d0216187bf678e10 https://github.com/LinuxCNC/linuxcnc/commit/f6eea6847fe42f70ef877cd6d0216187bf678e10 Author: Luca Toniolo <107...@us...> Date: 2026-10-14 (Wed, 14 Oct 2026) Changed paths: M src/emc/rs274ngc/gcode_renderer.cc M src/emc/rs274ngc/gcode_renderer.hh M tests/glcanon/test_workplane.py Log Message: ----------- Merge pull request #4679 from grandixximo/preview-plane-cut preview: a cut from where left-out traverses went counts toward the plane Compare: https://github.com/LinuxCNC/linuxcnc/compare/b36e0d1822ec...f6eea6847fe4 To unsubscribe from these emails, change your notification settings at https://github.com/LinuxCNC/linuxcnc/settings/notifications |