[Emc-commit] [LinuxCNC/linuxcnc] 96e06e: change time pins to float

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

  Branch: refs/heads/master
  Home:   https://github.com/LinuxCNC/linuxcnc
  Commit: 96e06e2562bebb52c2c7b9cf19a8f819d6b440d8
      https://github.com/LinuxCNC/linuxcnc/commit/96e06e2562bebb52c2c7b9cf19a8f819d6b440d8
  Author: Rene Hopf <ren...@ma...>
  Date:   2026-10-03 (Sat, 03 Oct 2026)

  Changed paths:
    M docs/src/config/core-components.adoc
    M docs/src/hal/basic-hal.adoc
    M docs/src/hal/tools.adoc
    M docs/src/hal/tutorial.adoc
    M docs/src/man/man9/classicladder.9.adoc
    M docs/src/man/man9/encoder.9.adoc
    M docs/src/man/man9/motion.9.adoc
    M lib/python/gladevcp/builtin-panels/gtk_mesa_tests/gtk_mesa_tests.glade
    M lib/python/gladevcp/builtin-panels/gtk_mesa_tests/gtk_mesa_tests.py
    M scripts/hal-histogram
    M src/hal/hal_lib.c
    M src/hal/hal_priv.h
    M src/hal/utils/halcmd_commands.cc
    M src/hal/utils/halrmt.cc
    M tests/halcompile/personalities_mod/4count_2pers.expected
    M tests/halcompile/personalities_mod/4names_2pers.expected
    M tests/halmodule/halquery/expected
    M tests/threads.1/checkresult

  Log Message:
  -----------
  change time pins to float

  Commit: 22bbf38e8f48e42072fe9035d6dd6f326838f2f6
      https://github.com/LinuxCNC/linuxcnc/commit/22bbf38e8f48e42072fe9035d6dd6f326838f2f6
  Author: Rene Hopf <ren...@ma...>
  Date:   2026-10-03 (Sat, 03 Oct 2026)

  Changed paths:
    M docs/src/config/core-components.adoc
    M docs/src/drivers/hal_pi_gpio.adoc
    M docs/src/hal/basic-hal.adoc
    M docs/src/hal/tutorial.adoc
    M docs/src/man/man9/classicladder.9.adoc
    M docs/src/man/man9/encoder.9.adoc
    M docs/src/man/man9/motion.9.adoc
    M lib/python/gladevcp/builtin-panels/gtk_mesa_tests/gtk_mesa_tests.py
    M src/hal/hal_lib.c
    M src/hal/hal_priv.h
    M tests/alias.0/expected
    M tests/halcompile/personalities_mod/4count_2pers.expected
    M tests/halcompile/personalities_mod/4names_2pers.expected
    M tests/halmodule/halquery/expected
    M tests/halmodule/halquery/halquerytest.py
    M tests/loadrt.1/expected
    M tests/loadrt.2/expected
    M tests/save.0/expected
    M tests/twopass-personality/expected
    M tests/twopass/expected

  Log Message:
  -----------
  change tmax from a param to a pin

The .time runtime value was already a pin while .tmax was a HAL_RW
parameter. Make .tmax an ordinary pin too, so both can be netted to
signals and read with the usual pin tooling.

It is created HAL_IO rather than HAL_OUT so that it stays writable, as
HAL_RW was: 'setp <funct>.tmax 0' still resets the recorded maximum, and
sim_pin (which accepts IN and I/O pins) still works on it.

.tmax-increased remains a parameter.

free_funct_struct() cleared funct->runtime but not funct->maxtime, since
only pin refs need clearing before the struct is reused; now that maxtime
is a pin it has to be cleared too, otherwise halpr_pin_new() reports
"already-initialized memory". free_thread_struct() cleared none of its
pin refs, so clear runtime, maxtime and threadbeat there as well.

Note that plain 'halcmd save' no longer emits a setp line for .tmax,
because it only saves parameters; 'save allu' covers unconnected pins.

Co-Authored-By: Claude Opus 5 <no...@an...>

  Commit: 19d59b2567e79ab4d4fe4902613943caaea0feb4
      https://github.com/LinuxCNC/linuxcnc/commit/19d59b2567e79ab4d4fe4902613943caaea0feb4
  Author: Rene Hopf <ren...@ma...>
  Date:   2026-10-03 (Sat, 03 Oct 2026)

  Changed paths:
    M docs/src/drivers/hal_pi_gpio.adoc
    M docs/src/hal/basic-hal.adoc
    M docs/src/hal/tutorial.adoc
    M docs/src/man/man9/motion.9.adoc
    M src/hal/hal_lib.c
    M src/hal/hal_priv.h
    M src/hal/utils/halcompile.g
    M tests/alias.0/expected
    M tests/halcompile/halname/test.sh
    M tests/halcompile/personalities_mod/4count_2pers.expected
    M tests/halcompile/personalities_mod/4names_2pers.expected
    M tests/halmodule/halquery/expected
    M tests/halmodule/halquery/halquerytest.py
    M tests/halmodule/halquery/test.hal
    M tests/loadrt.1/expected
    M tests/loadrt.2/expected
    M tests/twopass-personality/expected
    M tests/twopass/expected

  Log Message:
  -----------
  change tmax-increased from a param to a pin

With .time and .tmax already pins, make .tmax-increased one too, so a HAL
function brings three pins and no parameters with it. It is HAL_OUT, the
pin equivalent of the HAL_RO it replaces: only the RT code writes it.

free_funct_struct() must clear funct->maxtime_increased for the same
reason it clears the other two: halpr_pin_new() reports
"already-initialized memory" when a struct comes back off the free list
with a non-NULL pin ref.

Tests that list parameters had to be updated, and tests/save.0 loses the
'setp <funct>.tmax' lines because plain 'save' only writes parameters.
halquery now also loads 'invert', because and2/or2/xor2 have no
parameters of their own and the query API's parameter paths would
otherwise go untested.

Co-Authored-By: Claude Opus 5 <no...@an...>

  Commit: e8a02761ceaf0a01add0e0b090e9cf4402c3f748
      https://github.com/LinuxCNC/linuxcnc/commit/e8a02761ceaf0a01add0e0b090e9cf4402c3f748
  Author: Rene Hopf <ren...@ma...>
  Date:   2026-10-11 (Sun, 11 Oct 2026)

  Changed paths:
    M docs/src/config/core-components.adoc
    M docs/src/drivers/hal_pi_gpio.adoc
    M docs/src/hal/basic-hal.adoc
    M docs/src/hal/tools.adoc
    M docs/src/hal/tutorial.adoc
    M docs/src/man/man9/classicladder.9.adoc
    M docs/src/man/man9/encoder.9.adoc
    M docs/src/man/man9/motion.9.adoc
    M lib/python/gladevcp/builtin-panels/gtk_mesa_tests/gtk_mesa_tests.glade
    M lib/python/gladevcp/builtin-panels/gtk_mesa_tests/gtk_mesa_tests.py
    M scripts/hal-histogram
    M src/hal/hal_lib.c
    M src/hal/hal_priv.h
    M src/hal/utils/halcmd_commands.cc
    M src/hal/utils/halcompile.g
    M src/hal/utils/halrmt.cc
    M tests/alias.0/expected
    M tests/halcompile/halname/test.sh
    M tests/halcompile/personalities_mod/4count_2pers.expected
    M tests/halcompile/personalities_mod/4names_2pers.expected
    M tests/halmodule/halquery/expected
    M tests/halmodule/halquery/halquerytest.py
    M tests/halmodule/halquery/test.hal
    M tests/loadrt.1/expected
    M tests/loadrt.2/expected
    M tests/save.0/expected
    M tests/threads.1/checkresult
    M tests/twopass-personality/expected
    M tests/twopass/expected

  Log Message:
  -----------
  Merge pull request #4518 from rene-dev/time-float

change time pins to float

Compare: https://github.com/LinuxCNC/linuxcnc/compare/6fa6e06d13ac...e8a02761ceaf

To unsubscribe from these emails, change your notification settings at https://github.com/LinuxCNC/linuxcnc/settings/notifications