[Emc-commit] [LinuxCNC/linuxcnc] c83e08: Fix issues in 'momentary2nist' and 'toggle2nist' c...

[Luca T. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/LinuxCNC/linuxcnc
  Commit: c83e0881cbebb91456b1f194d76303e3551ab25c
      https://github.com/LinuxCNC/linuxcnc/commit/c83e0881cbebb91456b1f194d76303e3551ab25c
  Author: david mueller <mue...@ho...>
  Date:   2026-09-21 (Mon, 21 Sep 2026)

  Changed paths:
    M src/hal/components/momentary2nist.comp
    M src/hal/components/toggle2nist.comp

  Log Message:
  -----------
  Fix issues in 'momentary2nist' and 'toggle2nist' components

- Both 'momentary2nist' and 'toggle2nist' suffer from a loose pulse_length counter that leads
to 'on'-,'off'-signals getting cut short because the counter is not reset properly and counts when idling.
Fix: The counter is now reset when the pins are changed and no longer counts when the component is idle.

- 'toggle2nist' can endup being desynchronized when the toggle switch is flipped back and forth very fast.
Fix: The input pin state is now compared to the state of the device so a switch position disagreeing with
the device state will always trigger a change.

- Both components now verify a succesful change in the device by comparing to the expected state rather than
  output pin values that change in idle.

- For both components the idle state is now the default branch.

- remove unnecessary debounce reset when waiting for device confirmation

- set max_pulse_length to a more suitable default value and make it the minimum for toggle2nist

- clarification in the description


  Commit: f218ffbf0d182c2c438ffaaaa2743f33ad75e6ff
      https://github.com/LinuxCNC/linuxcnc/commit/f218ffbf0d182c2c438ffaaaa2743f33ad75e6ff
  Author: Luca Toniolo <107...@us...>
  Date:   2026-09-24 (Thu, 24 Sep 2026)

  Changed paths:
    M src/hal/components/momentary2nist.comp
    M src/hal/components/toggle2nist.comp

  Log Message:
  -----------
  Merge pull request #4576 from Sigma1912/2nist_comps-fix-issues

Fix issues in 'momentary2nist' and 'toggle2nist' components


Compare: https://github.com/LinuxCNC/linuxcnc/compare/61e56d782f8f...f218ffbf0d18

To unsubscribe from these emails, change your notification settings at https://github.com/LinuxCNC/linuxcnc/settings/notifications