[Emc-commit] [LinuxCNC/linuxcnc] 15f3bf: halmodule: fix inverted float to bool, unterminate...

[BsAtHome <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/LinuxCNC/linuxcnc
  Commit: 15f3bf10b853b0327a65196713e8f63473b07744
      https://github.com/LinuxCNC/linuxcnc/commit/15f3bf10b853b0327a65196713e8f63473b07744
  Author: Luca Toniolo <107...@us...>
  Date:   2026-09-19 (Sat, 19 Sep 2026)

  Changed paths:
    M src/hal/halmodule.cc
    M tests/halmodule/comp-set-get/expected
    M tests/halmodule/comp-set-get/test.py

  Log Message:
  -----------
  halmodule: fix inverted float to bool, unterminated RTType table, missing PyErr_Format argument

from_python(PyObject *, bool *) set the bool to true when the float was 0.0 and false otherwise, so writing 1.0 to a bool pin or param cleared it and writing 0.0 set it. The comment above it already stated the intended rule; the comparison is now "!= 0.0".

halenum_rt_members[] had no empty terminator, so halenum_build("RTType", ...) kept reading past the end of the array until it found a NULL name in whatever followed in .rodata. Whether the enum built correctly depended on the memory layout of the build.

check_port() passed two arguments to a format with three conversions, so the "Pin type not HAL_PORT" message printed the type where the pin name belongs and read garbage for the type.

tests/halmodule/comp-set-get now writes floats and ints into a bool param and checks what comes back.


  Commit: 260f61e2a9d56ef9e8c7dae6e4b2060eb71e2969
      https://github.com/LinuxCNC/linuxcnc/commit/260f61e2a9d56ef9e8c7dae6e4b2060eb71e2969
  Author: BsAtHome <be...@va...>
  Date:   2026-09-19 (Sat, 19 Sep 2026)

  Changed paths:
    M src/hal/halmodule.cc
    M tests/halmodule/comp-set-get/expected
    M tests/halmodule/comp-set-get/test.py

  Log Message:
  -----------
  Merge pull request #4568 from grandixximo/halmodule-fixes

halmodule: fix inverted float to bool, unterminated RTType table, missing PyErr_Format argument


Compare: https://github.com/LinuxCNC/linuxcnc/compare/972a90b3a83a...260f61e2a9d5

To unsubscribe from these emails, change your notification settings at https://github.com/LinuxCNC/linuxcnc/settings/notifications