[Emc-commit] [LinuxCNC/linuxcnc] 658951: qtplasmac: fix double "qtvcp" ghost windows on rep...

[Greg C. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/LinuxCNC/linuxcnc
  Commit: 6589510e2264bb42cc38d09368c275c03659a1b6
      https://github.com/LinuxCNC/linuxcnc/commit/6589510e2264bb42cc38d09368c275c03659a1b6
  Author: Greg Carl <260...@us...>
  Date:   2026-06-08 (Mon, 08 Jun 2026)

  Changed paths:
    M lib/python/qtvcp/lib/qtplasmac/conversational.py
    M share/qtvcp/screens/qtplasmac/qtplasmac_handler.py
    M share/qtvcp/screens/qtplasmac/versions.html

  Log Message:
  -----------
  qtplasmac: fix double "qtvcp" ghost windows on repeated switches to the conversational tab

conv_clear_widgets() calls setParent(None) on all widgets when leaving the conversational tab. On the next entry, conv_setup() calls conv_new_pressed(None) which calls the set_line_...() functions that call .show() on now un-parented widgets.  This results in two brief top level windows titled "qtvcp" flashing on screen.

This was only triggered on subsequent conversational tab visits, not the first, since the widgets are only unparented after first the conv_clear_widgets() call.  It also did't affect the NEW button since the widgets are still parented.

It's unclear why this behavior was not noticed earlier.  Probably a change in Qt or window manager behavior made the unparented widget .show() calls visible.  I figured this level of digging was deep enough.

Fixed by adding the "and button" guard to skip the set_line_...() calls in conv_new_pressed() when called with button=None from conv_setup(), as conv_shape_request() immediately rebuilds the layout correctly anyways.



To unsubscribe from these emails, change your notification settings at https://github.com/LinuxCNC/linuxcnc/settings/notifications