#128 Add current tool pin to IoControl.cc

[Marius Liebenberg]

Can we please add the current tool information to a pin in the IoControl.cc code. It has been done already by Arceye and is attached below.

This information is required when users create custom tool changer components.

[Sebastian Kuzminsky]

Is this different from the iocontrol.0.tool-number pin we already have? Does it add more pins in addition to that one? (The attached thing is a file, not a patch, so i can't easily see what's changed.)

[Marius Liebenberg]

Sorry that it is not a patch. I did not write the code Arceye (Mickey)
did and I would not know how to start making a patch :( .
The changes are marked with "NEW" If you search for that you will see
them all.
Two extra pins are added. One to prompt the update of the current tool
and another that contains the current tool.
The pin that we have right now hold the requested tool but not the
current tool. When you startup it is not possible to know what the
current tool is. The change take care of that as well.

------ Original Message ------
From: "Sebastian Kuzminsky" seb_kuzminsky@users.sf.net
To: "[emc:feature-requests] " 128@feature-requests.emc.p.re.sf.net
Sent: 2015-02-23 16:57:34
Subject: [emc:feature-requests] #128 Add current tool pin to
IoControl.cc

Is this different from the iocontrol.0.tool-number pin we already have?
Does it add more pins in addition to that one? (The attached thing is a
file, not a patch, so i can't easily see what's changed.)

---

[feature-requests:#128] Add current tool pin to IoControl.cc

Status: open
Group:
Created: Mon Feb 23, 2015 07:21 AM UTC by Marius Liebenberg
Last Updated: Mon Feb 23, 2015 07:21 AM UTC
Owner: nobody

Can we please add the current tool information to a pin in the
IoControl.cc code. It has been done already by Arceye and is attached
below.

This information is required when users create custom tool changer
components.

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/emc/feature-requests/128

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions

[Sebastian Kuzminsky]

On 02/23/2015 08:32 AM, Marius Liebenberg wrote:

The changes are marked with "NEW" If you search for that you will see
them all.

My first comment is: don't put NEW" into the code. It gets old. ;-)

Two extra pins are added. One to prompt the update of the current tool
and another that contains the current tool.
The pin that we have right now hold the requested tool but not the
current tool. When you startup it is not possible to know what the
current tool is. The change take care of that as well.

So one pin goes from the toolchanger hal circuit into IO, and tells IO
what tool the toolchanger currently has in the spindle?

And the other pin comes out of IO and says what tool IO thinks we
currently have in the spindle? How is this pin different from
iocontrol.0.tool-number?

I'd be happy to look at this change, but as a patch against master.
Arceye has submitted patches before, he knows the procedure. It's not
hard, and it makes it much easier for reviewers.

--
Sebastian Kuzminsky

[Marius Liebenberg]

I will ask him to take it up.

------ Original Message ------
From: "Sebastian Kuzminsky" seb_kuzminsky@users.sf.net
To: "[emc:feature-requests] " 128@feature-requests.emc.p.re.sf.net
Sent: 2015-02-23 18:21:01
Subject: [emc:feature-requests] Re: #128 Add current tool pin to
IoControl.cc

On 02/23/2015 08:32 AM, Marius Liebenberg wrote:

The changes are marked with "NEW" If you search for that you will see
them all.

My first comment is: don't put NEW" into the code. It gets old.

Two extra pins are added. One to prompt the update of the current tool
and another that contains the current tool.
The pin that we have right now hold the requested tool but not the
current tool. When you startup it is not possible to know what the
current tool is. The change take care of that as well.

So one pin goes from the toolchanger hal circuit into IO, and tells IO
what tool the toolchanger currently has in the spindle?

And the other pin comes out of IO and says what tool IO thinks we
currently have in the spindle? How is this pin different from
iocontrol.0.tool-number?

I'd be happy to look at this change, but as a patch against master.
Arceye has submitted patches before, he knows the procedure. It's not
hard, and it makes it much easier for reviewers.

--
Sebastian Kuzminsky

---

[feature-requests:#128] Add current tool pin to IoControl.cc

Status: open
Group:
Created: Mon Feb 23, 2015 07:21 AM UTC by Marius Liebenberg
Last Updated: Mon Feb 23, 2015 02:57 PM UTC
Owner: nobody

Can we please add the current tool information to a pin in the
IoControl.cc code. It has been done already by Arceye and is attached
below.

This information is required when users create custom tool changer
components.

---

Sent from sourceforge.net because you indicated interest in
https://sourceforge.net/p/emc/feature-requests/128

To unsubscribe from further messages, please visit
https://sourceforge.net/auth/subscriptions