[ejuf-cvs] ejuf/src/java/core/ejuf/assertions EqualityAssertionsImpl.java,1.1,1.2
Brought to you by:
fbos
|
From: <fb...@us...> - 2002-12-23 23:36:30
|
Update of /cvsroot/ejuf/ejuf/src/java/core/ejuf/assertions
In directory sc8-pr-cvs1:/tmp/cvs-serv5814/core/ejuf/assertions
Modified Files:
EqualityAssertionsImpl.java
Log Message:
Corrected a bug where float and double comparison would fail if the expected value was larger than the actual value. This was due to a failure to use Math.abs() while comparing values.
Index: EqualityAssertionsImpl.java
===================================================================
RCS file: /cvsroot/ejuf/ejuf/src/java/core/ejuf/assertions/EqualityAssertionsImpl.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -C2 -d -r1.1 -r1.2
*** EqualityAssertionsImpl.java 15 Nov 2002 14:09:59 -0000 1.1
--- EqualityAssertionsImpl.java 23 Dec 2002 23:36:27 -0000 1.2
***************
*** 96,100 ****
public void assertEquals(String msg, float expected, float actual, float comparisonDelta) {
final ComparisonError e = new ComparisonError(msg, new Float(expected), new Float(actual));
! float valueDelta = actual - expected;
if (valueDelta <= comparisonDelta) {
assertionPassed(e);
--- 96,100 ----
public void assertEquals(String msg, float expected, float actual, float comparisonDelta) {
final ComparisonError e = new ComparisonError(msg, new Float(expected), new Float(actual));
! float valueDelta = Math.abs(actual - expected);
if (valueDelta <= comparisonDelta) {
assertionPassed(e);
***************
*** 110,114 ****
public void assertEquals(String msg, double expected, double actual, double comparisonDelta) {
final ComparisonError e = new ComparisonError(msg, new Double(expected), new Double(actual));
! double valueDelta = actual - expected;
if (valueDelta <= comparisonDelta) {
assertionPassed(e);
--- 110,114 ----
public void assertEquals(String msg, double expected, double actual, double comparisonDelta) {
final ComparisonError e = new ComparisonError(msg, new Double(expected), new Double(actual));
! double valueDelta = Math.abs(actual - expected);
if (valueDelta <= comparisonDelta) {
assertionPassed(e);
|