|
From: Tomas G. <to...@pr...> - 2004-07-13 09:27:14
|
I see the point in AccessRulesdataBean. When the PrimearyKey class is a subset if the data fields the primary key in the database is also a compound primary key as in HARDTOKENPROPERTYDATA for example (which is godo I think). I don't quite get the point for AdminGroupDataBean though. The primary key is just a field. Perhaps it qould be better to have is as a compound key (adminGroupName, cAId)? Philip would be best to determine if (adminGroupName, cAId) is a good primary key. Perhaps not since it is a random number today...It's not completely unusual to have a primary key nopt related to the data though. Philip is away working abroad for a few weeks unforturnately... When changing database tables, please take a minute to consider upgrade scripts (located in ejbca/src/upgrade). /Tomas Stephane Bailliez wrote: > Cool, thanks for the feedback. > > I started to make some changes in AccessRulesDataBean and > AdminEntityBean to have correct PKs. > > I'm looking at the implementation of AdminGroupDataBean as it creates > the PKs directly and I'm not sure it is very wise. > Normally we can get the PK from the entity with getPrimaryKey and if we > need to compare entities we can use the isIdentical(EJBObject) method, > so there might be something to look at when trying to remove duplicate > entities.. > > Stephane > > Philipp Faerber <phi...@ad...> wrote: > >> >> Hi, >> >> we have ported EJBCA to WLS 8.1, and WLS also complained about the bad >> PK fields; >> for one thing, we have converted int to Integer. Also, we have added >> an explicit >> FK field for the admin-group relation, like so: >> <abstract-schema-name>AdminEntityDataBean</abstract-schema-name> >> <cmp-field><field-name>adminGroupFK</field-name></cmp-field> >> >> As soon as I find time, I will go through the diffs and write up the >> other relevant >> changes we did to get the entire application running on WLS. Plus post >> the >> weblogic-specifix xml files. >> >> (What we also did, is separate the RA and CA by having a Java Client >> make periodic >> requests from one full EJBCA-Instance running as 'CA' to as second >> instance >> which is used as an RA. If people are interested, I can also post more >> details on this). >> >> > > > > > ------------------------------------------------------- > This SF.Net email sponsored by Black Hat Briefings & Training. > Attend Black Hat Briefings & Training, Las Vegas July 24-29 - digital > self defense, top technical experts, no vendor pitches, unmatched > networking opportunities. Visit www.blackhat.com > _______________________________________________ > Ejbca-develop mailing list > Ejb...@li... > https://lists.sourceforge.net/lists/listinfo/ejbca-develop |