Re: [eclipsedarcs-develop] PATCH: Initial Refactor of IRLChanges and friends

[Leif F. <hi...@le...>]

Hi Isaac,

very nice, thanks :-)

> I've refactored the Changes code so now that IRLTag extend IRLPatch.
> There is a patch in there which took away the getTag/setTag methods of
> IRLPatch. Obsoleted by the patch by Leif - as a result did the resolve
> conflicit patch. Still apply it though.
> 
> How the changes displays now:
> 
> * Ordered by most recent to least recent (like a changelog).
>  Tags are now sorted by Date - with the patches. I want to add
> something like a Comparator that could be changed in an interface
> somewhere to change the sorting.
Yes. In the long run, it may be best to have an option for the user for 
this (But we can wait until the first users requests it ;-), so that you 
can choose the sort order from the view menu.

> 
> * Patches only appear once - underneath their tag or under the Changes
> root if they have no tag.
> 
> In the description of  "Refactored the Changes Code" patch I mention a
> regression. This isn't actually a bug --- After investigation it turns
> out that some ofthe patches by Matt Lavin were actually added after
> the tags were made but in his(?) repository were made sooner so they
> should be below the tags. Is this desirable? (I don't think so)
Hey, interesting case. Looking at the tree as it is now, it looks 
strange, but technically it is correct. If I see correctly, they will go 
into the next tag, when it is done. So we have by accident generated a 
nice demonstration of the mind-boggling features of quantum logic ;-).

We can resolve this by categorizing patches and tags in the viewer 
sorter (like it is done with files and folders), so that we have always 
all patches first and then the tags.

> 
> It's close to midnight here and I'm really tired - sorry if this
> doesn't make sense.
> 
> P.S. Also I have a heap of warnings and an error in my Problems view -
> is this just me or do you have it as well?
Nope, mine looks fine (just 8 warnings). Perhaps you have by accident 
Eclipse running on a Java 5 VM? This sometimes generates hundreds of 
'Incompatible class file version' warnings.

Ciao,
Leif

> 
> thanks,
> 
> Isaac