Re: [eclipsedarcs-develop] [PATCH] Tidyup + Factory Generalizations + Other tidbits
Status: Alpha
Brought to you by:
radoslawg
From: Leif F. <hi...@le...> - 2005-08-08 08:14:51
|
>>Two minor remarks here: I think we should go with the Java conventions >>here and make static constants all-uppercase (as in this case the >>tracing option constant is). I also would prefer no tabs and, if we can >>agree on this, using curly brackets on single-line if and while >>constructs (as specified here: >>http://java.sun.com/docs/codeconv/html/CodeConventions.doc6.html#449). I >>know that's partly a matter of taste, but I think a common guideline >>would be a good thing, and since we're still only a handful developers >>... Any comments are welcome :-) > > > Ofcourse I agree with it and I am trying comply with it using > checkstyle. but this you already know. ;) Yupp :-) I was more thinking in the direction of new developers who might join in the next time. If we have a single place where we can point them, we save us the time to explain and them the time to search the archive ;-) > >>The other thing: We should decide whether we need to internationalize >>log messages. Personally, I always feel that developers need a working >>knowledge of English, so I'm usually too lazy to externalize and >>translate everything that doesn't get to the user (in dialogs etc.). So >>I suggest we create i18n keys only for things the user is likely to see, >>and keep to writing simple strings to the log (or to the trace). It >>makes the code a bit better readable. Comments welcome on that topic too ... > > > Well, I already did some translation to polish language as I like > application speak to me using my tounge. I don't think we should > translate log messages. This is wrong beacause of bug reports. If user > copy pastes her logs only developers who knows i.e. polish language > will know what is going on. I assume that if darcs user do not know > english she will not be able to find logs.. (event fluent eclipse > users sometimes don't know where logs are. :-/ ) > These are my 2 cents. Right. Btw: I also thought I could make a translation into German. Usually, translations are in a separate fragment (i.e. a sort of plugin, only that it is tied to a 'host' plugin and has a fragment.xml instead of the plugin.xml). I'll create one for the core and ui plugins and put the German translation file into it. I think there should be little disagreement that the default language will be English ;-)) > > >>>As a result of the Factory/Manager changes quite a lot of code is now >>>in NewRepositoryLocationWizard.performFinish - is that kind of code >>>supposed to go there? Should an Action class or something be made for >>>that? >> >>Yes I think that would be preferable, especially because Radek will >>probably use them in his dialogs too, so we can avoid a bit of redundancy. > > > Oh, I have heard my name.. Cool. ;) Anyway, this is a good place to > say that my slowliness lately is because we are preparing our products > for testing phase. So I think I'll be able to send some patches (and > review this Isaac patch) next week. :/ Sorry for that. No hurry. The signs are good for me this week that I may have a bit of time, actually, so I hope I will get a bit done this week too :-) Ciao, Leif > > Cheers, > Radek. > |