Re: [eclipsedarcs-develop] Add Dialog implementation and small one liner

[Leif F. <hi...@le...>]

Hi Radek,

here we go, partly I can answer already (see below), the rest follows in 
another mail.

>   so here it is. I think my Add Dialog is ready for publicity. There
> are some enhancement that could be done but I am rather happy for now.
> (TODO List is in AddDialog.java file)
> 
> Changes includes Add Dialog itself, obviously change in Add Action and
> New preference options. Feel free to change text shown there. I always
> had trouble writing such stuff.
> 
> I had some troubles with PDE "style-guides" and If you have some time
> to answer my doubts I will gladly read it:
> 
> * I am not very sure how to handle radio buttons in preferences. CVS
> plugin does it by comparing stored value against (i.e.) "ext" string
> (this string is inline in the code). I had followed this but my
> possible storage values are in IUIDarcsPreferenceNames. I don't know
> whether this is correct.
> 
> * Just out of curiosity why our Actions implements just
> "IObjectActionDelegate" as other team plugins extends TeamAction? I am
> not saying this is wrong.. not at all.. But TeamAction has some nice
> helper utilities which would come handy. Anyway I don't feel
> knowledgeful enough to change it by myself. ;)
I have thought about using TeamAction, but unfortunately it is in an 
'internal' package, which makes it non-API, and it is bad practice to 
use it, because it might change without notice. I think we should avoid 
using any 'internal' code (since one of the latest versions of Eclipse 
3.1 it is even possible to check that as a compile error). We could, on 
the other hand, try to contact someone from the Eclipse team and ask 
whether it could be made API.

Since I'm just trying out the bug tracker, I've added a low

> * Today there is no possibility to select both files and folder at the
> same time and submit Add Action. Do we want to fix it? How? by doing
> popup menu for IResource? This would be to general I think. I have no
> clue.
Yes, that's a little unfortunate. But I may not be a big problem, since 
we have now the dialog, and I think one of the most common cases is that 
you would just add one or two files you have just created. Anyway, we 
can wait whether someone complains ;-).

> 
> Other patch attached is one liner. In one of test suits I think you
> mean other variable. Simply look in the patch. This fixes warning and
> now our project is problemless. :)
Absolutely :-) When I had a look at that code again, I remembered that I 
  should add some kind of caching, so that the pending file is not 
parsed so often (it's very often, actually, as it is now, and I think it 
causes some flickering, which isn't nice).

> 
> Anyway, as these patches start to grow I think I will start to zip
> them. Unfortunatly GMAIL does not allow me to send zip files so I add
> .dat extension. Just rename it and unzip. (or unzip without renaming..
> up to you ;) )
Fine. No problem :-)

> 
> How is bug issue tracking system testing going on?
Well, I have now filed a bit (see above ;-) and I'd say it looks fine to 
me. It has everything we need, so from my point of view we could give it 
a go and see how it works out in the daily business :-)

I have linked it from the start page of the homepage. Could you perhaps 
have it at a different server context, so that the version number is not 
in the URL? It would be good if the bug tracking URL would not change 
when we chould make an update.

Thanks && ciao,
Leif

> 
> uff, this was long email and I hate to write.. ;)
> 
> Cheers,
>   Radek.
>