|
From: Ladislav U. <lad...@we...> - 2005-12-27 23:44:18
|
Hi David,
the problem is the setXXX method adds new element to ebxml header. This
element is empty because for example role parameter of SetFromRole is
null.
So lets suppose I do have a generator what pre-fills my ebxml message.
There is no value for role so it creates empty element role.
Later on I add role value but I do have one empty element Role and yet
another with my value.
You are right I should print some warning message if the parameter role
is null too.
If I add role "unknown" this would not be true and I am not sure if it
is allowed by standard.
Ladislav
PS. We work on certification so every tiny issue in ebxml message is
important.
On Tue, 2005-12-27 at 15:19 -0700, David RR Webber (XML) wrote:
> Ladistan,
>
> I'm not totally clear on this - why are you just not giving an error
> or assigning 'unknown' to the role if they do not provide one?
>
> DW
>
>
>
> -------- Original Message --------
> Subject: [ebxmlms-general] Bug in the ebxml header
> From: Ladislav Urban <lad...@we...>
> Date: Tue, December 27, 2005 3:59 pm
> To: ebxmlms-general <ebx...@li...>,
> ebxmlms-develop <ebx...@li...>
>
> Hello hermes developers,
> I have found bug in ebxml header. For example if I call
> setFromRole(null) with null value. This method creates empty
> Element
> <eb:Role/> . This problem is repeated in setToRole and
> possibly other
> methods.
> I fixed the problem:
>
> Do you agree with this solution?
>
>
> public void setToRole(String role) throws SOAPException {
> if (role != null) {
>
> if (toRole == null) {
> if (toPartyIds.size() > 0) {
> to.addChildElement(ELEMENT_ROLE, role);
> }
> toRole = role;
> } else {
> throw new SOAPValidationException(
>
> SOAPValidationException.SOAP_FAULT_CLIENT, "<"
> + NAMESPACE_PREFIX_EB + ":" +
> ELEMENT_ROLE
> + "> has already been " + "set
> in <"
> + NAMESPACE_PREFIX_EB + ":" +
> ELEMENT_TO
> + ">!");
> }
>
> }
> }
>
>
>
>
>
>
>
> <eb:From>
> <eb:PartyId
> eb:type="urn:oasis:names:tc:ebxml-cppa:partyid-type:duns">AutoMateHub</eb:PartyId>
> <eb:Role/>
> <eb:Role>Seller</eb:Role>
> </eb:From>
> <eb:To>
> <eb:PartyId
> eb:type="urn:oasis:names:tc:ebxml-cppa:partyid-type:duns">TestDriver</eb:PartyId>
> <eb:Role>Buyer</eb:Role>
> </eb:To>
>
> --
> Ladislav Urban
> CEO
> Webswell Inc.
> 1333 Howe Avenue, Suite 100
> Sacramento, 95825 CA
> email: lad...@we...
> phone: +1 (916) 290-2040
> fax: +1 (916) 921-2850
> http://www.webswell.com
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep
> through log files
> for problems? Stop! Download the new AJAX search engine that
> makes
> searching your log files as easy as surfing the web.
> DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________
> ebxmlms-general mailing list
> ebx...@li...
> https://lists.sourceforge.net/lists/listinfo/ebxmlms-general
> ------------------------------------------------------- This SF.net
> email is sponsored by: Splunk Inc. Do you grep through log files for
> problems? Stop! Download the new AJAX search engine that makes
> searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
> _______________________________________________ ebxmlms-general
> mailing list ebx...@li...
> https://lists.sourceforge.net/lists/listinfo/ebxmlms-general
--
Ladislav Urban
CEO
Webswell Inc.
1333 Howe Avenue, Suite 100
Sacramento, 95825 CA
email: lad...@we...
phone: +1 (916) 290-2040
fax: +1 (916) 921-2850
http://www.webswell.com
|