Re: [E1000-devel] [net-next v2 1/8] i40e: main driver core

[Nelson, S. <sha...@in...>]

> -----Original Message-----
> From: David Miller [mailto:da...@da...]
> Sent: Friday, August 23, 2013 12:28 AM

[...]

>
> > +{
> > +	int i;
> > +	struct i40e_pf *pf = vsi->back;
>
> Please order local variable declarations from longest line to shortest.

I understand the aesthetics as it does make the code look a little cleaner, and we can do this with a lot of our functions.  However, there are several instances where one declaration initialization depends on a previous declaration, and trying to organize by line length breaks these relationships.  Do you mind if we're not perfect on following this one?

Also, perhaps I haven't watched closely enough, but I don't remember seeing this comment on other code.  Is this a new recommendation that will be going into the CodingStyle document?

Thanks,
sln