[E-p-i-c-commits] org.epic.debug/src/org/epic/debug/ui/action VariablesViewActionDelegate.java, NONE, 1.1 ShowVarAddressActionDelegate.java, 1.1, 1.2 ShowPerlInternalVariableActionDelegate.java, 1.3, 1.4 ShowGlobalVariableActionDelegate.java, 1.3, 1.4 ShowLocalVariableActionDelegate.java, 1.3, 1.4 HighlightVarUpdatesActionDelegate.java, 1.1, 1.2

[Jan P. <jp...@us...>]

Update of /cvsroot/e-p-i-c/org.epic.debug/src/org/epic/debug/ui/action
In directory sc8-pr-cvs17:/tmp/cvs-serv17222/src/org/epic/debug/ui/action

Modified Files:
	ShowVarAddressActionDelegate.java 
	ShowPerlInternalVariableActionDelegate.java 
	ShowGlobalVariableActionDelegate.java 
	ShowLocalVariableActionDelegate.java 
	HighlightVarUpdatesActionDelegate.java 
Added Files:
	VariablesViewActionDelegate.java 
Log Message:
- Removed PerlDB, made PerlDebugThread the central class
- Redesigned DebuggerInterface to only support synchronous communication with the debugger, made PerlDebugThread responsible for issuing asynchronous commands
- Hopefully fixed bug [ 1705011 ] CGI,no breakpoints,100% cpu perl.exe zombies,ignore use lib through introduction of epic_breakpoints.pm to deal with ambiguous paths

Index: ShowVarAddressActionDelegate.java
===================================================================
RCS file: /cvsroot/e-p-i-c/org.epic.debug/src/org/epic/debug/ui/action/ShowVarAddressActionDelegate.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- ShowVarAddressActionDelegate.java	26 Apr 2007 16:32:07 -0000	1.1
+++ ShowVarAddressActionDelegate.java	27 May 2007 14:30:34 -0000	1.2
@@ -1,48 +1,18 @@
 package org.epic.debug.ui.action;
 
 import org.eclipse.jface.action.IAction;
-import org.eclipse.jface.viewers.ISelection;
-import org.eclipse.swt.widgets.Event;
-import org.eclipse.ui.IViewActionDelegate;
-import org.eclipse.ui.IViewPart;
-import org.epic.debug.db.PerlDB;
 
-public class ShowVarAddressActionDelegate implements IViewActionDelegate, org.eclipse.ui.IActionDelegate2
+public class ShowVarAddressActionDelegate extends VariablesViewActionDelegate
 {
     private static IAction action;
 
-    public void init(IViewPart view)
-    {
-    }
-
     public void init(IAction action)
     {
         ShowVarAddressActionDelegate.action = action;
     }
 
-    public void dispose()
-    {
-    }
-
-    public void runWithEvent(IAction action, Event event)
-    {
-        PerlDB.updateVariablesView();
-    }
-
-    public void run(IAction action)
-    {
-    }
-
-    public void selectionChanged(IAction action, ISelection selection)
-    {
-    }
-
     public static boolean getPreferenceValue()
     {
         return action == null ? false : action.isChecked();
     }
-
-    public void update()
-    {
-    }
 }
\ No newline at end of file

Index: ShowLocalVariableActionDelegate.java
===================================================================
RCS file: /cvsroot/e-p-i-c/org.epic.debug/src/org/epic/debug/ui/action/ShowLocalVariableActionDelegate.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- ShowLocalVariableActionDelegate.java	26 Apr 2007 16:32:07 -0000	1.3
+++ ShowLocalVariableActionDelegate.java	27 May 2007 14:30:34 -0000	1.4
@@ -1,52 +1,18 @@
 package org.epic.debug.ui.action;
 
 import org.eclipse.jface.action.IAction;
-import org.eclipse.jface.viewers.ISelection;
-import org.eclipse.swt.widgets.Event;
-import org.eclipse.ui.IViewActionDelegate;
-import org.eclipse.ui.IViewPart;
-import org.epic.debug.db.PerlDB;
 
-public class ShowLocalVariableActionDelegate implements IViewActionDelegate, org.eclipse.ui.IActionDelegate2
+public class ShowLocalVariableActionDelegate extends VariablesViewActionDelegate
 {
     private static IAction action;
 
-    public ShowLocalVariableActionDelegate()
-    {
-    }
-
-    public void init(IViewPart view)
-    {
-    }
-
     public void init(IAction action)
     {
         ShowLocalVariableActionDelegate.action = action;
     }
 
-    public void dispose()
-    {
-    }
-
-    public void runWithEvent(IAction action, Event event)
-    {
-        PerlDB.updateVariablesView();
-    }
-
-    public void run(IAction action)
-    {
-    }
-
-    public void selectionChanged(IAction action, ISelection selection)
-    {
-    }
-
     public static boolean getPreferenceValue()
     {
         return action == null ? true : action.isChecked();
     }
-
-    public void update()
-    {
-    }
 }
\ No newline at end of file

Index: HighlightVarUpdatesActionDelegate.java
===================================================================
RCS file: /cvsroot/e-p-i-c/org.epic.debug/src/org/epic/debug/ui/action/HighlightVarUpdatesActionDelegate.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- HighlightVarUpdatesActionDelegate.java	1 May 2007 22:15:58 -0000	1.1
+++ HighlightVarUpdatesActionDelegate.java	27 May 2007 14:30:34 -0000	1.2
@@ -1,48 +1,18 @@
 package org.epic.debug.ui.action;
 
 import org.eclipse.jface.action.IAction;
-import org.eclipse.jface.viewers.ISelection;
-import org.eclipse.swt.widgets.Event;
-import org.eclipse.ui.IViewActionDelegate;
-import org.eclipse.ui.IViewPart;
-import org.epic.debug.db.PerlDB;
 
-public class HighlightVarUpdatesActionDelegate implements IViewActionDelegate, org.eclipse.ui.IActionDelegate2
+public class HighlightVarUpdatesActionDelegate extends VariablesViewActionDelegate
 {
     private static IAction action;
 
-    public void init(IViewPart view)
-    {
-    }
-
     public void init(IAction action)
     {
         HighlightVarUpdatesActionDelegate.action = action;
     }
 
-    public void dispose()
-    {
-    }
-
-    public void runWithEvent(IAction action, Event event)
-    {
-        PerlDB.updateVariablesView();
-    }
-
-    public void run(IAction action)
-    {
-    }
-
-    public void selectionChanged(IAction action, ISelection selection)
-    {
-    }
-
     public static boolean getPreferenceValue()
     {
         return action == null ? false : action.isChecked();
     }
-
-    public void update()
-    {
-    }
 }
\ No newline at end of file

Index: ShowPerlInternalVariableActionDelegate.java
===================================================================
RCS file: /cvsroot/e-p-i-c/org.epic.debug/src/org/epic/debug/ui/action/ShowPerlInternalVariableActionDelegate.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- ShowPerlInternalVariableActionDelegate.java	26 Apr 2007 16:32:06 -0000	1.3
+++ ShowPerlInternalVariableActionDelegate.java	27 May 2007 14:30:34 -0000	1.4
@@ -1,48 +1,18 @@
 package org.epic.debug.ui.action;
 
 import org.eclipse.jface.action.IAction;
-import org.eclipse.jface.viewers.ISelection;
-import org.eclipse.swt.widgets.Event;
-import org.eclipse.ui.IViewActionDelegate;
-import org.eclipse.ui.IViewPart;
-import org.epic.debug.db.PerlDB;
 
-public class ShowPerlInternalVariableActionDelegate implements IViewActionDelegate, org.eclipse.ui.IActionDelegate2
+public class ShowPerlInternalVariableActionDelegate extends VariablesViewActionDelegate
 {
     private static IAction action;
 
-    public void init(IViewPart view)
-    {
-    }
-
     public void init(IAction action)
     {
         ShowPerlInternalVariableActionDelegate.action = action;
     }
 
-    public void dispose()
-    {
-    }
-
-    public void runWithEvent(IAction action, Event event)
-    {
-        PerlDB.updateVariablesView();
-    }
-
-    public void run(IAction action)
-    {
-    }
-
-    public void selectionChanged(IAction action, ISelection selection)
-    {
-    }
-
     public static boolean getPreferenceValue()
     {
         return action == null ? false : action.isChecked();
     }
-
-    public void update()
-    {
-    }
 }
\ No newline at end of file

Index: ShowGlobalVariableActionDelegate.java
===================================================================
RCS file: /cvsroot/e-p-i-c/org.epic.debug/src/org/epic/debug/ui/action/ShowGlobalVariableActionDelegate.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- ShowGlobalVariableActionDelegate.java	26 Apr 2007 16:32:07 -0000	1.3
+++ ShowGlobalVariableActionDelegate.java	27 May 2007 14:30:34 -0000	1.4
@@ -1,48 +1,18 @@
 package org.epic.debug.ui.action;
 
 import org.eclipse.jface.action.IAction;
-import org.eclipse.jface.viewers.ISelection;
-import org.eclipse.swt.widgets.Event;
-import org.eclipse.ui.IViewActionDelegate;
-import org.eclipse.ui.IViewPart;
-import org.epic.debug.db.PerlDB;
 
-public class ShowGlobalVariableActionDelegate implements IViewActionDelegate, org.eclipse.ui.IActionDelegate2
+public class ShowGlobalVariableActionDelegate extends VariablesViewActionDelegate
 {
     private static IAction action;
 
-    public void init(IViewPart view)
-    {
-    }
-
     public void init(IAction action)
     {
         ShowGlobalVariableActionDelegate.action = action;
     }
 
-    public void dispose()
-    {
-    }
-
-    public void runWithEvent(IAction action, Event event)
-    {
-        PerlDB.updateVariablesView();
-    }
-
-    public void run(IAction action)
-    {
-    }
-
-    public void selectionChanged(IAction action, ISelection selection)
-    {
-    }
-
     public static boolean getPreferenceValue()
     {
         return action == null ? false : action.isChecked();
     }
-
-    public void update()
-    {
-    }
 }
\ No newline at end of file

--- NEW FILE: VariablesViewActionDelegate.java ---
package org.epic.debug.ui.action;

import org.eclipse.debug.core.DebugException;
import org.eclipse.debug.core.DebugPlugin;
import org.eclipse.debug.core.model.*;
import org.eclipse.jface.action.IAction;
import org.eclipse.jface.viewers.ISelection;
import org.eclipse.swt.widgets.Event;
import org.eclipse.ui.*;
import org.epic.debug.DebugTarget;
import org.epic.debug.PerlDebugPlugin;
import org.epic.debug.db.StackFrame;

abstract class VariablesViewActionDelegate
    implements IViewActionDelegate, IActionDelegate2
{
    public void init(IViewPart view)
    {
    }

    public void run(IAction action)
    {
    }

    public void selectionChanged(IAction action, ISelection selection)
    {
    }

    public void dispose()
    {
    }

    public void init(IAction action)
    {
    }

    public void runWithEvent(IAction action, Event event)
    {
        updateVariablesView();
    }

    protected final void updateVariablesView()
    {
        IDebugTarget[] targets =
            DebugPlugin.getDefault().getLaunchManager().getDebugTargets();
        
        for (int i = 0; i < targets.length; i++)
        {
            if (!(targets[i] instanceof DebugTarget)) continue;
            DebugTarget target = (DebugTarget) targets[i];
            
            try
            {
                IThread[] threads = target.getThreads();
                IStackFrame[] frames = threads[0].getStackFrames();
    
                for (int j = 0; j < frames.length; j++)
                    ((StackFrame) frames[j]).discardCachedVars();
            }
            catch (DebugException e)
            {
                PerlDebugPlugin.log(e);
            }
        }
    }
}