#644 syntax highlighting fails

[Anonymous]

the syntaxhihighlighting breaks for the following code

sub extract_objects_from_makefile {

# return an array of all used .o files from makefile

my ($file) = @_;
my @objects = 0;

open ( MAKEFILE, "<$file" ) || die_call( "\nvia open(r) of $file\n$!\n" );
while (<MAKEFILE>) { last if ( m/^\s*OBJ\s*\=/ ); }
s/\#.+$//;
s/^\s*OBJ\=\s*//;
s/\\\s*$//;
s/\s+$//;
@objects = split /\s+/, $_;

while (<MAKEFILE>) {
last if ( m/^\s*$/ );
s/\#.+$//;
s/\\\s*$//;
s/\s+$//;
s/^\s+//;
push @objects, split /\s+/, $_;
}
close MAKEFILE;

return @objects;
}

[dyakov]

Fails on split /\s+/, $line;, right after last / and until nearest +.

Is fixed by adding m or using {} in the code. I'd say this is very serious problem: it can break both syntax highlight and code parsing. e.g. in my code the area of "confusion" (from / to nearest +) includes a subroutine declaration, so this subroutine is completely invisible to parser.

[Jan Ploski]

Also fixed by using the syntax split(/\s+/, $line); which seems like a good idea anyway (make function parameter lists appear as such).

[dyakov]

... which, of course, does not mean this EPIC bug does not need to be fixed. This bug severely depletes EPIC's usefulness for browsing through the code.

[Oliver Trosien]

Just tested with 0.7.0. The syntax highlighting looks good. Closing as fixed.