#318 Task tags are not regex escaped

[Dirk Bergstrom]

I commonly use "XXX???" as a task tag in my code. EPIC
fails to properly regex-escape this, and when I open a
perl file, I get the error below. If I change the tag
to "XXX\?\?\?", then I don't get the error, and EPIC
recognizes "XXX???" as a task tag.

The error dump:
java.util.regex.PatternSyntaxException: Dangling meta
character '?' near index 9
#\s*XXX???
^
at java.util.regex.Pattern.error(Pattern.java:1650)
at java.util.regex.Pattern.sequence(Pattern.java:1787)
at java.util.regex.Pattern.expr(Pattern.java:1687)
at java.util.regex.Pattern.compile(Pattern.java:1397)
at java.util.regex.Pattern.<init>(Pattern.java:1124)
at java.util.regex.Pattern.compile(Pattern.java:840)
at
org.epic.perleditor.editors.TasksReconciler.initSearchPatterns(TasksReconciler.java:106)
at
org.epic.perleditor.editors.TasksReconciler.reconcile(TasksReconciler.java:61)
at
org.epic.perleditor.editors.PerlEditor$1.run(PerlEditor.java:393)
at
org.eclipse.swt.widgets.Synchronizer.syncExec(Synchronizer.java:152)
at
org.eclipse.ui.internal.UISynchronizer.syncExec(UISynchronizer.java:28)
at
org.eclipse.swt.widgets.Display.syncExec(Display.java:3722)
at
org.epic.perleditor.editors.PerlEditor.reconcile(PerlEditor.java:386)
at
org.epic.perleditor.editors.PerlEditor.createPartControl(PerlEditor.java:99)
at
org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:596)
at
org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:372)
at
org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:566)
at
org.eclipse.ui.internal.EditorReference.getEditor(EditorReference.java:214)
at
org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2595)
at
org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2528)
at
org.eclipse.ui.internal.WorkbenchPage.access$10(WorkbenchPage.java:2520)
at
org.eclipse.ui.internal.WorkbenchPage$9.run(WorkbenchPage.java:2505)
at
org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
at
org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2500)
at
org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2485)
at org.eclipse.ui.ide.IDE.openEditor(IDE.java:388)
at org.eclipse.ui.ide.IDE.openEditor(IDE.java:350)
at
org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:275)
at
org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:139)
at
org.eclipse.jdt.internal.ui.actions.OpenActionUtil.open(OpenActionUtil.java:49)
at
org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:190)
at
org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:174)
at
org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchRun(SelectionDispatchAction.java:267)
at
org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(SelectionDispatchAction.java:243)
at
org.eclipse.jdt.internal.ui.packageview.PackageExplorerActionGroup.handleOpen(PackageExplorerActionGroup.java:306)
at
org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart$4.open(PackageExplorerPart.java:653)
at
org.eclipse.jface.viewers.StructuredViewer$2.run(StructuredViewer.java:817)
at
org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
at
org.eclipse.core.runtime.Platform.run(Platform.java:843)
at
org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:44)
at
org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:149)
at
org.eclipse.jface.viewers.StructuredViewer.fireOpen(StructuredViewer.java:815)
at
org.eclipse.jface.viewers.StructuredViewer.handleOpen(StructuredViewer.java:1069)
at
org.eclipse.jface.viewers.StructuredViewer$6.handleOpen(StructuredViewer.java:1168)
at
org.eclipse.jface.util.OpenStrategy.fireOpenEvent(OpenStrategy.java:249)
at
org.eclipse.jface.util.OpenStrategy.access$2(OpenStrategy.java:243)
at
org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:283)
at
org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
at
org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1085)
at
org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3166)
at
org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2842)
at
org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1914)
at
org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1878)
at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:419)
at
org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at
org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:95)
at
org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:78)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:92)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:68)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:400)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at
org.eclipse.core.launcher.Main.invokeFramework(Main.java:336)
at org.eclipse.core.launcher.Main.basicRun(Main.java:280)
at org.eclipse.core.launcher.Main.run(Main.java:977)
at org.eclipse.core.launcher.Main.main(Main.java:952)

[Jan Ploski]

Logged In: YES
user_id=86907

Fixed in CVS.

[Jan Ploski]

Logged In: YES
user_id=86907

Fixed in 0.4.15/0.5.15.