Menu
▾
▴
5 Attachments
#139 Positive Final Mill Depth Values Treated as Negative
Greetings;
I am trying out the latest version (2022.2.26) and quickly noticed that any positive final mill depth values set in the GUI are treated as negative values. So if I have a workpiece top of 19, infeed of 12, and final depth of 2mm, it then creates tool paths at 7mm and -2mm. I have tested with a few different files and the results seem to be the same. I will include the project, results, and both configs used. Let me know if I can be of any further assistance in solving this. Thank you.
Looking over the code, I think the culprit is the line here taking the negative absolute value of depth: https://sourceforge.net/p/dxf2gcode/sourcecode/ci/develop/tree/source/dxf2gcode/core/shape.py#l401
I am not well versed in Python or most coding in general, but assuming the release candidate download is based on the "develop" tree, this feels like it's probably the cause.
My material thickness varies constantly, so I always treat the workpiece bottom as my depth zero and nearly all my cuts have positive depth, so this is a pretty serious problem. I thought about half the CNC world worked this way.
hey folks, thanks for the awesome tool.
I work with Adam, don't really know my way around milling/gcode but I do know coding/python pretty well. I had a look around and may have identified the line that might be causing the issue for us, it's at:
https://sourceforge.net/p/dxf2gcode/sourcecode/ci/develop/tree/source/dxf2gcode/core/shape.py#l401
which is from this commit:
https://sourceforge.net/p/dxf2gcode/sourcecode/ci/67a72fbab2a3f6f36d0b79349281129b3a1b0618/
which does say "Added some more improvement to make mill depth absolute and remove potential failures due to wrong sign." so seems like design.
any insight on what the correct procedure should be here? since it seems like the app previously was working ok for this scenario.
Hi Dom hi Adam,
your right, this was a issue some other people had. They confused the +/- sign and therefore i made this change to stop people from doing stupid things. However, with the issue you discribed it should be possible to have positive start and end positions, right? So the only thing which will always be negative is the slice depth? So just remove the abs in:
https://sourceforge.net/p/dxf2gcode/sourcecode/ci/develop/tree/source/dxf2gcode/core/shape.py#l401
https://sourceforge.net/p/dxf2gcode/sourcecode/ci/develop/tree/source/dxf2gcode/core/shape.py#l411
Maybe also here:
https://sourceforge.net/p/dxf2gcode/sourcecode/ci/develop/tree/source/dxf2gcode/core/shape.py#l397
Can you try that and give feedback, so i will update the code accordingly if ok?
regards
christian
Closed with:
https://sourceforge.net/p/dxf2gcode/sourcecode/ci/8a5b053e58bcbf7a11bc147195d622a645da9d14/