#6 Enable AVI in dir2slideshow and dvd-slideshow; Bugs

[Marc Wäckerlin]

For my changes in detail, please see the attached patch file (it's a patch to the actual (todays) repository). If you give me write access to the repository, I will redo the changes cleaned up and check them in.

I would be glad if you could add my changes as soon as possible. Thank you.

Here is a description of what I did and why:

===================================================
File: dir2slideshow
===================================================

First of all: Support of AVI in dir2slideshow was missing, so I added it.

This change is very simple:
1) Add "-name \*.avi" to all image-find-statements
2) Add "elif [ "$filetype" == 'avi' ] ; then"
3) Don't add "crossfade" or "wipe" before or after an image.
-> new check for $nextfiletype

IDEA: Instead of "crossfade" or "wipe", "fadein" and "fadeout" could be used. (But pay attention to the fact that two avi could follow each other, so you would also need to check the previous type)

PROBLEM: The very first and very last element must be an image, otherwise there would be a "fadein" or "fadeout" to/from an avi.

---------------------------------------------------

There was a bug, at the same lines in several find statements:

BUG: Wrong number in $pictures

EFFECTS: There was one crossfade too much, just before fadeout at the end

REASON: You need to put "-type f -o -type l" in brackets and append the second brackets (the file types) with "-a".

---------------------------------------------------

===================================================
File: dvd-slideshow
===================================================

BUG: Encoding in ffmpeg of tmp.avi hangs at the seconf *.avi file.

REASON: The old tmp.avi file was not removed. "ffmpeg" asks, whether the file should be overwritten. This question is invisible because of output redirection (to /dev/null).

SOLUTION: Add 'rm "$tmpdir"/tmp.avi' after 'encode_video "$tmpdir"/tmp.avi'

[Marc Wäckerlin]

Patch as described above, result of: svn diff

[Scott Dylewski]

Thanks for all the great suggestions and fixes!
I don't plan on adding avi to dir2slideshow yet because it's not fully working in dvd-slideshow. I'll look into it for future releases, though!
I fixed the "wrong number in $pictures" bug in the latest svn code. thanks!
I also implemented your avi hang fix, but haven't tested it. It will be available for testing in the next svn update.
I'd consider adding you as a developer if you wish. contact me if you're still interested.