RE: [Dunit-interest] Bug - [ 487903 ] GUI freezes occasionally - FIX?!?!

[<jua...@ca...>]

Mike,

I haven't tested for this bug, but I think it is very likely that the
cause is what you describe.

The only problem I forsee with the solution is for apps that are doing
their own Application stuff and launch the DUnit GUI in the middle of
things.

How about putting the old behavior in a RunTestModal (also
RunRegisteredTestsModal), and including your fix with some attempt at
trying to find out if Application has already been initialized (MainForm
=3D nil?).

Juanco
--
Juancarlo A=F1ez
Computing Engineer
mailto:ju...@su...
http://www.suigeneris.org/juanca
+58 (412) 222-1160  Cel.
---


-----Original Message-----
From: dun...@li...
[mailto:dun...@li...] On Behalf Of Michael
A. Johnson
Sent: Thursday, September 12, 2002 11:50 AM
To: dun...@li...
Subject: [Dunit-interest] Bug - [ 487903 ] GUI freezes occasionally -
FIX?!?!


=20
I can confirm this bug is real. Mainly by empirical observation.
Usually I just have to hit ctrl-f2 to reset the app.  My guess is
because the gui is started up in a manner not expected by the Delphi
runtime environment.
=20
The old code looked like:
=20
procedure RunTest(test: ITest);
var
  myform: TGUITestRunner;
begin
  Application.Initialize;
  Application.Title :=3D 'DUnit';
  Application.CreateForm(TGUITestRunner, MyForm);
  with MyForm do
  begin
    try
      suite :=3D test;
      ShowModal;
    finally
      Free;
    end;
  end;
end;
=20
I have modified the code to look more like what Delphi typically writes
for a GUI main:
=20
=20
procedure RunTest(test: ITest);
var
  myform: TGUITestRunner;
begin
  Application.Initialize;
=20
  Application.Title :=3D 'DUnit';
=20
  Application.CreateForm(TGUITestRunner, MyForm);
=20
  MyForm.Suite :=3D test;
=20
  Application.Run;=20
end;
=20
=20
The problem with this bug/code is that I don=92t have any test to prove
the existence of the bug or prove that this code change actually will
solve the problem. This is just one of those programming by side-effect
issues I guess. I would like feedback on why or why not this is a good
idea (especially those working the gui testing side of things, does this
cause problems with the messageQueue that I=92m not aware of?). If this
changes seems ok and isn=92t hurting people I=92ll check my mod into SF =
this
evening.
=20
--Mike