Re: [Dump-devel] [patch] Support for ext4 filesystems under linux.

[Stelian P. <st...@po...>]

Hi Gertjan,

On Tue, May 26, 2009 at 12:50:14PM -0700, Gertjan van Wingerde wrote:

> I've created a patch for dump to properly dump ext4 filesystems under Linux.
> It currently only works on Linux as it heavily depends on the ext2fs
> library, which is only used on Linux for dumping regular files.

First of all, thanks for your patch. I suppose this require a recent
version of ext2fs libs ?

However, I'm a bit puzzled because I thought ext4 was quite different than
ext3, and your patch seems way too simple to make dump work on ext4.

In particular, dump does raw seeks on the underlying disk device and
reads fixed size blocks, and I thought ext4, with its "extent" format,
has changed this. But maybe I'm wrong and the ext2fs library is able
to cope with all the differences.

I have to admit that I (still) haven't had the time to look at ext4 yet,
so I really cannot comment further on the validity of this patch.

So if somebody else here can give this a try it would be great.

Stelian.

-- 
Stelian Pop <st...@po...>