Re: [Dump-devel] [patch] cron_dump_to_disk example

[Aaron S. H. <aar...@gm...>]

This patch uses environment variables for certain values if they're
set to determine the backup partition, backup directory and the file
systems to backup.

Also included in the patch are whitespace changes to some output
messages, and a typo fix.  Use what you like.

I like the environment variable approach, because I store the settings
in a file of the form:

# /etc/dumprc -- configuration file for dump backups

FSTODUMP="/ /var /home /boot"

export FSTODUMP

## end-of-file

and then use a cron job script of this form:

# /etc/cron.daily/dump -- daily dump backup cron job

. /etc/dumprc

backup_rotate && nice -1 backup inc

## end-of-file

The patch is also attached.
/a

Index: backup
===================================================================
RCS file: /cvsroot/dump/dump/examples/cron_dump_to_disk/backup,v
retrieving revision 1.3
diff -u -r1.3 backup
--- backup	18 Apr 2008 08:42:47 -0000	1.3
+++ backup	2 May 2008 23:17:35 -0000
@@ -31,10 +31,10 @@
 # Configuration Parameters
 #

-BACKUPPART="/backup"
+BACKUPPART=${BACKUPPART:-"/backup"}
-BACKUPDIR="current"
+BACKUPDIR=${BACKUPDIR:-"current"}
 DUMPLOGARCH="$BACKUPPART/backup.dump.log.gz"
-FSTODUMP="/ /var /home /mnt/hdb1 /usr"
+FSTODUMP=${FSTODUMP:-/ /var /home /mnt/hdb1 /usr}
 DUMPFILESMODE="0644"
 DUMPFILESOWN="root.root"

@@ -81,17 +81,17 @@

    if [ `expr $SAVAIL - $SREQ` -gt "0" ]; then
       echo "done."
-      echo " Available: $SAVAIL MB Required: $SREQ MB."
+      echo "Available: $SAVAIL MB Required: $SREQ MB."
    else
       echo "no enough space!"
-      echo " There is not enough space left in $BACKUPPART for the backup!"
+      echo "There is not enough space left in $BACKUPPART for the backup!"
-      echo " Available: $SAVAIL MB Required: $SREQ MB."
+      echo "Available: $SAVAIL MB Required: $SREQ MB."
       echo -n "Remounting backup partition read-only ... "
       if ( mount $BACKUPPART -o remount,ro &> /dev/null ) then
          echo "done."
       else
          echo "failure!"
-         echo " There were problems remounting $BACKUPPART in read-only mode!"
+         echo "There were problems remounting $BACKUPPART in read-only mode!"
          echo "Aborting ${BACKUP} System Dump Backup."
          echo "Aborted."
          echo "-------------------------------------------------------------------------------"
@@ -120,14 +120,14 @@
          FSNAME=`echo $FS|tr / _|cut -b 2-`
       fi
       sync
-      echo -n " Starting dump of $FSNAME ( $FS ) ... "
+      echo -n "Starting dump of $FSNAME ( $FS ) ... "
       if ( dump -$DLEVEL $UPDATEDDATE -z -M -s 27306 -f
$BACKUPPART/$BACKUPDIR/$FSNAME.$BTYPE. $FS &>
$BACKUPPART/$BACKUPDIR/$FSNAME.log ) then
          echo "done."
       else
          echo "problems!"
-         echo " There where problems with the dump of $FSNAME ( $FS )."
+         echo "There where problems with the dump of $FSNAME ( $FS )."
-         echo " Check logfile $BACKUPPART/$BACKUPDIR/$FSNAME.log for more info"
+         echo "Check logfile $BACKUPPART/$BACKUPDIR/$FSNAME.log for more info"
-         echo " Also check log archive file $DUMPLOGARCH."
+         echo "Also check log archive file $DUMPLOGARCH."
       fi
       cat $BACKUPPART/$BACKUPDIR/$FSNAME.log |gzip >> $DUMPLOGARCH
       echo "-------------------------------------------------------------------------------"
|gzip >> $DUMPLOGARCH
@@ -145,14 +145,14 @@

 else
    echo "problems!"
-   echo " There are problems with the directory structure."
+   echo "There are problems with the directory structure."
-   echo " Check dirs: $BACKUPPART/$BACKUPDIR"
+   echo "Check dirs: $BACKUPPART/$BACKUPDIR"
    echo -n "Remounting backup partition read-only ... "
    if ( mount $BACKUPPART -o remount,ro &> /dev/null ) then
       echo "done."
    else
       echo "failure!"
-      echo " There were problems remounting $BACKUPPART in read-only mode!"
+      echo "There were problems remounting $BACKUPPART in read-only mode!"
       echo "Aborting ${BACKUP} System Dump Backup."
       echo "Aborted."
       echo "-------------------------------------------------------------------------------"
@@ -169,13 +169,13 @@
    echo "done."
 else
    echo "failure!"
-   echo " There were problems remounting $BACKUPPART in read-only mode!"
+   echo "There were problems remounting $BACKUPPART in read-only mode!"
    echo "Aborting ${BACKUP} System Dump Backup."
    echo "Aborted."
    echo "-------------------------------------------------------------------------------"
    exit 1
 fi

-echo "End of ${BACKUP} System Dump Backup."
+echo "### End of ${BACKUP} System Dump Backup ###"
 echo "Done."
 echo "-------------------------------------------------------------------------------"
Index: backup_rotate
===================================================================
RCS file: /cvsroot/dump/dump/examples/cron_dump_to_disk/backup_rotate,v
retrieving revision 1.1
diff -u -r1.1 backup_rotate
--- backup_rotate	30 Nov 2001 10:12:40 -0000	1.1
+++ backup_rotate	2 May 2008 23:17:35 -0000
@@ -3,7 +3,7 @@
 # This script will redirect the backup directory to implement desired backup
 # schedules.
 #
-# Currently we will use just a seven day format were we just move a link
+# We will use just a seven day format where we just move a link
 # that represents the backup directory, to point to the day of the week.
 #

@@ -17,8 +17,8 @@
    REALDIR=`date +%A`
 fi

-BACKUPPART="/backup"
+BACKUPPART=${BACKUPPART:-"/backup"}
-BACKUPDIR="current"
+BACKUPDIR=${BACKUPDIR:-"current"}

 echo "### Start of Backup Rotation ###"
 echo "Using backup partition: $BACKUPPART"


On 4/18/08, Stelian Pop <st...@po...> wrote:
>
>  Le vendredi 18 avril 2008 à 00:23 -0400, Aaron S. Hawley a écrit :
>
> > I have some patches for the cron_dump_to_disk example shipped with
>  > dump.  I submitted the first as a Sourceforge tracker item.  Stelian
>  > suggest I send the rest to this mailing list.
>  >
>
> [...]
>
>  Applied, thanks.
>
>
>  --
>  Stelian Pop <st...@po...>
>
>


-- 
Modern man suffers from a kind of poverty of the spirit which
stands in glaring contrast to his scientific and technological
abundance. We've learned to fly the air like birds, we've learned
to swim the seas as fish, yet we haven't learned to walk the
earth as brothers and sisters. -- Dr. Martin King