Menu

#29 No self defined IDs anymore

closed
nobody
None
5
2010-08-28
2010-08-26
No

"Literal IDs" are error prone and most of the time unnecessary. Getting rid of them makes the source code shorter and easier to maintain. Standard IDs of `wx` should be used if possible. Then there is no need to give the text of buttons and menu items, and on some platforms appropriate icons will be shown automatically. And the IDs `wx.ID_OK` and `wx.ID_CANCEL` have special meaning in `wx.Dialog`\s.

First patch is for `drFileDialogPrefs.py`.

Discussion

  • Marc 'BlackJack' Rintsch

     
  • Marc 'BlackJack' Rintsch

     
  • Marc 'BlackJack' Rintsch

     
  • Franz Steinhaeusler

    • status: open --> closed
     
  • Franz Steinhaeusler

    applied patches, thanks

     

Log in to post a comment.