SourceForge has been redesigned. Learn more.

Corrupt Icons Downloading Plugins

  • Daniel Pozmanter

    Download a plugin, and notice the icons are corrupt?

    Well, I finally found the problem:

    Line 630 in
    f = file(dir + '/' + zippedfile, 'w')

    if you simply add 'b':
    f = file(dir + '/' + zippedfile, 'wb')

    It works like a charm.  (Ooops).

    This will be in 3.6.2.

    Just thought I'd post here in case people thought it was the plugin zip.(3.6.2 should be out tomorrow, I want to do some bug hunting first)

    • Franz Steinhaeusler

      Hi Dan,

      Yesterday I uploaded SearchinFiles, now I tried to
      download it in 3.6.1.
      It complained:

      Traceback (most recent call last):
        File "C:\temp\drpython-3.6.1\", line 1699, in InitializePlugin
          exec(compile("import " + plugin, pluginfile, 'exec'))
        File "C://drpython/plugins/", line 1, in ?
          #    Programmer:    Franz Steinhaeusler
      SyntaxError: EOL while scanning single-quoted string (, line 687)

      I made a binary filecompare and discovered,
      the py file wasn't the same as I uploaded it.
      (I downloaded again SinFiles 1.2.2 and compared it.)
      DocList, SinFiles and FindFiles:

      I saw just now, that they were mixed line endings (also the uploaded files)
      Could it be changed, that this doesn't matter?
      Else I clean the plugin files again.
      The drpython_SearchInFiles.png is again 1730 byte big (corrupt file).

      One Suggestion: is there a possibility to list (when updating) only plugins, that are not installed or
      are a newer version, than those that are installed ?


    • Daniel Pozmanter

      For the future.  I'd have to either have plugins register their version with a function, or parse the plugin files for version info.


Log in to post a comment.