#50 Leopard Buff

[Vanoi]

Posted: Sun Jan 27, 2013 1:40 am Post subject:
AMeka: Deal 50% more to Mekas
Takes 25% less from Mekas

CE increased by 55
BD1 prereq added

AMeka 7 15 15
AMeka 5 8 10
AMeka 5 8 10

Same Armor, Shield and Actis.

Good?

Git: http://sourceforge.net/u/vanoi/dropshock/ci/8457cac57ffa9036b447fa8e8bf4a3c171cf4476/
https://sourceforge.net/u/vanoi/dropshock/ci/ffb7403744e7d37a41729b355150ea5cb07845e0/
https://sourceforge.net/u/vanoi/dropshock/ci/bd35dce2cd37821ef952be7fcbda229a07a07054/

[Frizzled]

Code needs work:

Unit type_ids should not be hard-coded into the damage modifiers:

An effect should be created which passed the unit's id into an array, that array should then be checked. See how $damMod_M, $damMod_E, $damMod_B are handled.

Line 4906 should not have been changed, the new effect should me something like $damMod_Meka and setup like the other $damMod_ ... arrays / effects.

[Vanoi]

Code redone

I also noticed a problem with how the reduction is done. Currently if you have an B/M/E reduction the DWA and the Leopard would be completely ignored... I will get to fixing that later.

[Vanoi]

• Description has changed:

Diff:

--- old
+++ new
@@ -13,4 +13,4 @@

 Good? 

-Git: https://sourceforge.net/u/vanoi/dropshock/ci/3b4a15fc37d684da4d2a9773c9616e1374e39997/
+Git: http://sourceforge.net/u/vanoi/dropshock/ci/8457cac57ffa9036b447fa8e8bf4a3c171cf4476/

• status: dev-work-needed --> council-approved

[Vanoi]

• Description has changed:

Diff:

--- old
+++ new
@@ -14,3 +14,4 @@
 Good? 

 Git: http://sourceforge.net/u/vanoi/dropshock/ci/8457cac57ffa9036b447fa8e8bf4a3c171cf4476/
+https://sourceforge.net/u/vanoi/dropshock/ci/ffb7403744e7d37a41729b355150ea5cb07845e0/

• status: dev-work-needed --> council-approved

[Vanoi]

• Description has changed:

Diff:

--- old
+++ new
@@ -15,3 +15,4 @@

 Git: http://sourceforge.net/u/vanoi/dropshock/ci/8457cac57ffa9036b447fa8e8bf4a3c171cf4476/
 https://sourceforge.net/u/vanoi/dropshock/ci/ffb7403744e7d37a41729b355150ea5cb07845e0/
+https://sourceforge.net/u/vanoi/dropshock/ci/bd35dce2cd37821ef952be7fcbda229a07a07054/

[Frizzled]

This code / ticket is a mess:

The links to 3 different branches are confusing, one branch is the old code, the other two have commits in about hanf a dozen branches. Close this ticket, make a new one, make a new branch with just the code that needs to be changed.

I'll fix the typo on my own.