[Drm-devel] Dream2019 and trunk

[Rafael D. <ra...@ri...>]

Hi all,

I can see some differences between dream2019 branch and trunk. When
trying to build dream2019 branch, I get:

g++ -c -pipe -O2 -D_REENTRANT -Wall -W -fPIC -DEXECUTABLE_NAME=dream
-DHAVE_DLFCN_H -DHAVE_MEMORY_H -DHAVE_STDINT_H -DHAVE_STDLIB_H
-DHAVE_STRINGS_H -DHAVE_STRING_H -DSTDC_HEADERS -DHAVE_INTTYPES_H
-DHAVE_STDINT_H -DHAVE_SYS_STAT_H -DHAVE_SYS_TYPES_H -DHAVE_UNISTD_H
-DHAVE_LIBZ -DHAVE_LIBFDK_AAC -DHAVE_LIBOPUS -DUSE_OPUS_LIBRARY
-DUSE_PULSEAUDIO -D_REENTRANT -DQT_NO_DEBUG -DQT_SVG_LIB
-DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_XML_LIB
-DQT_CORE_LIB -I../../dream2019 -I. -I../include -I../src/GUI-QT
-isystem /usr/include/x86_64-linux-gnu/qt5 -isystem
/usr/include/x86_64-linux-gnu/qt5/QtSvg -isystem
/usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem
/usr/include/x86_64-linux-gnu/qt5/QtGui -isystem
/usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem
/usr/include/x86_64-linux-gnu/qt5/QtXml -isystem
/usr/include/x86_64-linux-gnu/qt5/QtCore -Imoc -isystem
/usr/include/libdrm -Iui
-I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o obj/fdk_aac_codec.o
../src/sourcedecoders/fdk_aac_codec.cpp
In file included from ../src/sourcedecoders/fdk_aac_codec.h:32,
                 from ../src/sourcedecoders/fdk_aac_codec.cpp:29:
../src/sourcedecoders/AudioCodec.h: In member function ‘virtual
CAudioCodec::EDecError CAudioCodec::Decode(const std::vector<unsigned
char>&, uint8_t, std::vector<short int>&, int&)’:
../src/sourcedecoders/AudioCodec.h:59:53: warning: unused parameter
‘audio_frame’ [-Wunused-parameter]
     virtual EDecError Decode(const vector<uint8_t>& audio_frame,
uint8_t aac_crc_bits, vector<short>& samples, int& channels) { return
DECODER_ERROR_UNKNOWN; }
                              ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
../src/sourcedecoders/AudioCodec.h:59:74: warning: unused parameter
‘aac_crc_bits’ [-Wunused-parameter]
     virtual EDecError Decode(const vector<uint8_t>& audio_frame,
uint8_t aac_crc_bits, vector<short>& samples, int& channels) { return
DECODER_ERROR_UNKNOWN; }

~~~~~~~~^~~~~~~~~~~~
../src/sourcedecoders/AudioCodec.h:59:103: warning: unused parameter
‘samples’ [-Wunused-parameter]
     virtual EDecError Decode(const vector<uint8_t>& audio_frame,
uint8_t aac_crc_bits, vector<short>& samples, int& channels) { return
DECODER_ERROR_UNKNOWN; }

               ~~~~~~~~~~~~~~~^~~~~~~
../src/sourcedecoders/AudioCodec.h:59:117: warning: unused parameter
‘channels’ [-Wunused-parameter]
     virtual EDecError Decode(const vector<uint8_t>& audio_frame,
uint8_t aac_crc_bits, vector<short>& samples, int& channels) { return
DECODER_ERROR_UNKNOWN; }

                                       ~~~~~^~~~~~~~
../src/sourcedecoders/fdk_aac_codec.cpp: In member function ‘virtual
bool FdkAacCodec::CanDecode(CAudioParam::EAudCod)’:
../src/sourcedecoders/fdk_aac_codec.cpp:84:27: error: ‘CAPF_AAC_USAC’
was not declared in this scope
         if((linfo.flags & CAPF_AAC_USAC) != 0)
                           ^~~~~~~~~~~~~
../src/sourcedecoders/fdk_aac_codec.cpp:84:27: note: suggested
alternative: ‘CAPF_AAC_RVLC’
         if((linfo.flags & CAPF_AAC_USAC) != 0)
                           ^~~~~~~~~~~~~
                           CAPF_AAC_RVLC
../src/sourcedecoders/fdk_aac_codec.cpp: In function ‘void logAOT(const
CStreamInfo&)’:
../src/sourcedecoders/fdk_aac_codec.cpp:101:29: error:
‘AOT_DRM_SURROUND’ is not a member of ‘AUDIO_OBJECT_TYPE’
     case AUDIO_OBJECT_TYPE::AOT_DRM_SURROUND:
                             ^~~~~~~~~~~~~~~~
../src/sourcedecoders/fdk_aac_codec.cpp:105:29: error: ‘AOT_DRM_USAC’ is
not a member of ‘AUDIO_OBJECT_TYPE’
     case AUDIO_OBJECT_TYPE::AOT_DRM_USAC:
                             ^~~~~~~~~~~~
../src/sourcedecoders/fdk_aac_codec.cpp: In member function ‘virtual
bool FdkAacCodec::DecOpen(const CAudioParam&, int&)’:
../src/sourcedecoders/fdk_aac_codec.cpp:211:50: error: ‘AOT_DRM_USAC’ is
not a member of ‘AUDIO_OBJECT_TYPE’
         else if(pinfo->aot == AUDIO_OBJECT_TYPE::AOT_DRM_USAC) bUsac =
true;
                                                  ^~~~~~~~~~~~
../src/sourcedecoders/fdk_aac_codec.cpp: In member function ‘virtual
CAudioCodec::EDecError FdkAacCodec::Decode(const std::vector<unsigned
char>&, uint8_t, std::vector<short int>&, int&)’:
../src/sourcedecoders/fdk_aac_codec.cpp:325:30: warning: comparison of
integer expressions of different signedness: ‘unsigned int’ and ‘INT’
{aka ‘int’} [-Wsign-compare]
         for(unsigned i = 0; i<pinfo->frameSize; i++) {
                             ~^~~~~~~~~~~~~~~~~
../src/sourcedecoders/fdk_aac_codec.cpp:333:30: warning: comparison of
integer expressions of different signedness: ‘unsigned int’ and ‘INT’
{aka ‘int’} [-Wsign-compare]
         for(unsigned i = 0; i<pinfo->frameSize; i++) {
                             ~^~~~~~~~~~~~~~~~~
../src/sourcedecoders/fdk_aac_codec.cpp: In member function ‘virtual
bool FdkAacCodec::EncOpen(const CAudioParam&, long unsigned int&, long
unsigned int&)’:
../src/sourcedecoders/fdk_aac_codec.cpp:552:12: warning: enumeration
value ‘AM_RESERVED’ not handled in switch [-Wswitch]
     switch (AudioParam.eAudioMode) {
            ^
../src/sourcedecoders/fdk_aac_codec.cpp:584:12: warning: enumeration
value ‘AM_RESERVED’ not handled in switch [-Wswitch]
     switch (AudioParam.eAudioMode) {
            ^
../src/sourcedecoders/fdk_aac_codec.cpp: In member function ‘virtual int
FdkAacCodec::Encode(CVector<short int>&, long unsigned int,
CVector<unsigned char>&, long unsigned int)’:
../src/sourcedecoders/fdk_aac_codec.cpp:638:39: warning: unused
parameter ‘vecsEncInData’ [-Wunused-parameter]
 FdkAacCodec::Encode(CVector<_SAMPLE>& vecsEncInData, unsigned long
lNumSampEncIn, CVector<uint8_t>& vecsEncOutData, unsigned long
lMaxBytesEncOut)
                     ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
../src/sourcedecoders/fdk_aac_codec.cpp:638:68: warning: unused
parameter ‘lNumSampEncIn’ [-Wunused-parameter]
 FdkAacCodec::Encode(CVector<_SAMPLE>& vecsEncInData, unsigned long
lNumSampEncIn, CVector<uint8_t>& vecsEncOutData, unsigned long
lMaxBytesEncOut)

~~~~~~~~~~~~~~^~~~~~~~~~~~~
../src/sourcedecoders/fdk_aac_codec.cpp:638:101: warning: unused
parameter ‘vecsEncOutData’ [-Wunused-parameter]
 FdkAacCodec::Encode(CVector<_SAMPLE>& vecsEncInData, unsigned long
lNumSampEncIn, CVector<uint8_t>& vecsEncOutData, unsigned long
lMaxBytesEncOut)

          ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
../src/sourcedecoders/fdk_aac_codec.cpp:638:131: warning: unused
parameter ‘lMaxBytesEncOut’ [-Wunused-parameter]
 FdkAacCodec::Encode(CVector<_SAMPLE>& vecsEncInData, unsigned long
lNumSampEncIn, CVector<uint8_t>& vecsEncOutData, unsigned long
lMaxBytesEncOut)

                                            ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
../src/sourcedecoders/fdk_aac_codec.cpp: In member function ‘virtual
std::__cxx11::string FdkAacCodec::fileName(const CParameter&) const’:
../src/sourcedecoders/fdk_aac_codec.cpp:687:12: warning: enumeration
value ‘AM_RESERVED’ not handled in switch [-Wswitch]
     switch (Parameters.
            ^
../src/sourcedecoders/fdk_aac_codec.cpp: At global scope:
../src/sourcedecoders/fdk_aac_codec.cpp:165:13: warning: ‘void
logNumbers(const CStreamInfo&)’ defined but not used [-Wunused-function]
 static void logNumbers(const CStreamInfo& info) {
             ^~~~~~~~~~
make: *** [Makefile:2657: obj/fdk_aac_codec.o] Error 1


--

I'm using the following fdk-aac version:
ii  libfdk-aac-dev:amd64                   0.1.6-1
       amd64        Fraunhofer FDK AAC Codec Library - development files
ii  libfdk-aac1:amd64                      0.1.6-1
       amd64        Fraunhofer FDK AAC Codec Library - runtime files

Cheers,
Rafael Diniz