From: Alexander V. <av...@re...> - 2000-08-29 21:33:54
|
On Tue, 29 Aug 2000, Tigran Aivazian wrote: > On Tue, 29 Aug 2000, Rik Faith wrote: > > Could we export a function that answers the specific question that > > lookup_one(... , proc_mnt->mnt_root, ...) answers? > > I wouldn't want this to be proc-specific. E.g. I might want to ask the > same questions about devfs or some other kern-mounted > filesystems. Exporting a vfsmount structure for kern-mounted instance of > any FS_SINGLE filesystem may be a good idea, i.e. it provides full > "access" to such filesystem by drivers etc. That is precisely the reason why it is a _bad_ idea. Drivers have no business knowing about procfs and its guts. Incidentially, that is the reason why devfs design is a horse manure. Sorry. Tigran, I had a dubious pleasure of going through all drivers and cleaning up the worst parts of procfs mess. Trust me, it was ugly beyond belief. As for the shared part - it's going to be about 20 lines long, counting #include lines. No kidding - it's very easy. Having procfs shared by all drivers is _very_ painful. It's an artifact of the time when we had no way to leave almost everything to VFS and back then investing into the procfs infrastructure was the easiest thing to do. Now we can leave everything to dcache and let the driver ask for fs and populate it with objects it wants to have there. No dependencies on procfs, right amount of granularity (admin mounts what he wants) and no BS with hardwired locations(you are responsible for the structure of your tree and nothing else) |