Re: [Intel-gfx] [PATCH 1/2] libdrm: Move intel_atomic.h to libdrm core for sharing.

[Pauli N. <su...@gm...>]

On Wed, Mar 10, 2010 at 10:44 PM, Julien Cristau <jcr...@de...> wrote:
>> On Wed, Mar 10, 2010 at 11:20 AM, Pauli Nieminen <su...@gm...> wrote:
>> > intel_atomic.h includes very usefull atomic operations for
>> > lock free parrallel access of variables. Moving these to
>> > core libdrm for code sharing with radeon.
>> >
>> > Signed-off-by: Pauli Nieminen <su...@gm...>
>> > ---
>> >  Makefile.am          |    2 +-
>> >  configure.ac         |    2 +-
>> >  intel/intel_atomic.h |   56 +-----------------------------
>> >  xf86atomic.h         |   93 ++++++++++++++++++++++++++++++++++++++++++++++++++
>> >  4 files changed, 96 insertions(+), 57 deletions(-)
>> >  create mode 100644 xf86atomic.h
>> >
>> > diff --git a/Makefile.am b/Makefile.am
>> > index ee3ccc7..295121f 100644
>> > --- a/Makefile.am
>> > +++ b/Makefile.am
>> > @@ -59,7 +59,7 @@ libdrm_la_SOURCES =                           \
>> >        libdrm_lists.h
>> >
>> >  libdrmincludedir = ${includedir}
>> > -libdrminclude_HEADERS = xf86drm.h xf86drmMode.h
>> > +libdrminclude_HEADERS = xf86drm.h xf86drmMode.h xf86atomic.h
>> >
>
> Should this really get installed?  I'm not sure this should be public
> libdrm interface.
>
> Cheers,
> Julien
>

Inlte had it installed. And my patch adds it to radeon so that mesa
will reference it indirectly tough radeon_bo_int.h. Maybe dependency
in mesa to radeon_bo_int.h is bad idea in first place.