From: Alex D. <ale...@gm...> - 2009-06-30 21:51:08
|
On Tue, Jun 30, 2009 at 5:33 PM, Jesse Barnes<jb...@vi...> wrote: > Now that we're using the scaling property in the Intel driver I noticed > that the names were a bit confusing. I've corrected them according to > our discussion on IRC, though I've left out potential new additions for > a new scaling property with an integer (or two) for the scaling > factor. None of the drivers implement that today, but if someone wants > to do it, I think it could be done with the addition of a single new > type and a new property to describe the scaling factor in the X and Y > directions. > > Signed-off-by: Jesse Barnes <jb...@vi...> > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 8fab789..21d518f 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -68,10 +68,10 @@ DRM_ENUM_NAME_FN(drm_get_dpms_name, drm_dpms_enum_list) > */ > static struct drm_prop_enum_list drm_scaling_mode_enum_list[] = > { > - { DRM_MODE_SCALE_NON_GPU, "Non-GPU" }, > - { DRM_MODE_SCALE_FULLSCREEN, "Fullscreen" }, > - { DRM_MODE_SCALE_NO_SCALE, "No scale" }, > - { DRM_MODE_SCALE_ASPECT, "Aspect" }, > + { DRM_MODE_SCALE_NON_GPU, "Software" }, > + { DRM_MODE_SCALE_FULLSCREEN, "Full" }, > + { DRM_MODE_SCALE_NO_SCALE, "None" }, How about changing "None" to "Center" or adding "Center" as an alternate method as center tends to be what people look for as alternative to scaled modes. Alex > + { DRM_MODE_SCALE_ASPECT, "Full aspect" }, > }; > > static struct drm_prop_enum_list drm_dithering_mode_enum_list[] = > > ------------------------------------------------------------------------------ > -- > _______________________________________________ > Dri-devel mailing list > Dri...@li... > https://lists.sourceforge.net/lists/listinfo/dri-devel > |