Re: [Patch 3/3_v2]: [DRM/I915] : Sync the default modes for LVDS output device

[Eric A. <er...@an...>]

On Mon, 2009-03-23 at 11:30 +0800, yakui_zhao wrote:
> Subject: [DRM/I915]: Sync the default modes for LVDS output device
> From: Zhao Yakui <yak...@in...>
> 
> Sync the default modes for the LVDS output device
>     This covers:
>     Add the default modes for the LVDS output device.
>     The bit of edid->feature.msc indicates whether the display device is not
> continous-frequency. And it is used to determine whether the default modes will
> be added to the output device.
>     But for the LVDS output device the edid->feature.msc will always be set.Even
> when there is no edid, the correponding bit in the fake edid will be set.
> In such case the default modes will be added to LVDS output device.
>     If not, the different modes are obtained by using KMS/UMS.
> 
> Signed-off-by: Zhao Yakui <yak...@in...>

These giant tables of modes are insane.  Especially having a bunch of
different refresh rates when the LVDS actually has a fixed refresh rate.
Just generate a mode at each appropriate size using GTF or CVT.

I'm not really sold on the whole idea of the kernel generating these
fake modes for LVDS, given that we can support any size and that the
refresh rate is a lie since we're always using the fixed mode.  Any
other opinions on this?

-- 
Eric Anholt
er...@an...                         eri...@in...