Re: [PATCH] vblank rework for drm-next

[Dave A. <ai...@gm...>]

2008/9/4 Jesse Barnes <jb...@vi...>:
> On Wednesday, September 03, 2008 6:11 am Stefano Avallone wrote:
>> On Wednesday 03 September 2008 13:36:21 Maksym Veremeyenko wrote:
>> > Jesse Barnes написав(ла):
>> > [...]
>> >
>> > >> I am very interesting in getting drmWaitVBlank works on 945GME...
>> > >
>> > > It's against Dave's upstream DRM repo:
>> > > git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git
>> > > branch drm-next.
>> >
>> > downloaded repo:
>> > [root@np-1 src]# git clone
>> > git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git
>> >
>> > and patching cause a lot of errors:
>> > [root@np-1 drm-2.6]# patch -p1 < ../drm-next-vblank-rework-2.patch
>> > patching file drivers/gpu/drm/drm_drv.c
>> > patching file drivers/gpu/drm/drm_irq.c
>> > Hunk #2 succeeded at 221 with fuzz 2.
>> > Hunk #3 succeeded at 238 (offset -3 lines).
>> > Hunk #4 succeeded at 280 with fuzz 2.
>> > Hunk #5 succeeded at 322 (offset -3 lines).
>> > ....
>> >
>> > am i doing wrong?
>>
>> I guess you need to switch to the drm-next branch:
>>
>> cd drm-2.6
>> git checkout -b drm-next origin/drm-next
>
> Right; the vblank patch also depends on the other patches I posted
> (suspend/resume, GM45 and irq field removal).  It may apply with some fuzz if
> you don't have those patches but I don't know if it'll work.
>

I've applied the suspend/resume and GM45 ones, the irq removal I'm not
so sure I won't just have to revert
if we ever end up doing non PCI device support. so I'm not sure its a big win.

Dave.